fix: Raise events when adding or removing nodes due to filtering on Unix #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
force-pushed
the
unix-filter-events
branch
from
612e5cb to
7453714
Compare
DataTriny
force-pushed
the
unix-filter-events
branch
from
7453714 to
dda214b
Compare
|
Did you mean to mark this as a draft, or is it ready for review? |
|
I am still unsure whether it fixes all my issues, so it's not ready yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already create and destroy nodes in the DBus tree, but we also need to send appropriate events or otherwise ATs have no way of figuring out the changes.