Fix array handling for claims with multiple values #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirill-abblix
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
MergeClaimsmethod has been designed to correctly handle multiple claims of the same type by aggregating them into JSON arrays. This ensures that when a JWT contains multiple claims with the same type, they are represented as arrays in the payload, adhering to JWT standards.The
ToJsonNodemethod has been extended to support a broader range ofClaimValueTypes. This enhancement allows for accurate parsing and serialization of various claim value types into appropriateJsonNoderepresentations.Benefits
By correctly representing multiple claims of the same type as arrays, the JWTs generated are more compliant with JWT specifications.
These changes enhance compatibility with clients and services that expect claims to be structured in this manner, reducing potential integration issues.
The extended support for various
ClaimValueTypesensures that a wider range of claim data can be accurately processed and included in JWTs.