Skip to content

ST : Add STM32WBA platform to psa-arch-tests. #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

ST : Add STM32WBA platform to psa-arch-tests. #406

merged 2 commits into from
Jun 3, 2025

Conversation

ahmadstm
Copy link
Contributor

Added the "tgt_dev_apis_tfm_stm32wba" file for the STM32WBA platform to enable the execution of all PSA API tests.

This file is crucial for running all PSA API tests on the STM32WBA platform, ensuring compliance and robustness of security implementations.

This change allows for validation of PSA API implementations on STM32WBA , increasing test coverage and platform security.

All PSA API tests have been successfully executed on the STM32WBA platform, confirming compliance with specifications.

etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request May 28, 2025
@etienne-lms
boards: st: stm32wba65i_dk1: Add ns variant for TF-M support
9675e49 
Add variant ns to stm32wba65i_dk1 board to embed TF-M in the SoC
secure world. The flash layout is synced with the layout defined
in Zephyr TF-M integration of platform STM32WBA65I.

Successfully tested against a few samples and test samples:
- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request May 28, 2025
@etienne-lms
boards: st: nucleo_wba65ri: Add ns variant for TF-M support
66484e7 
Add variant ns to nucleo_wba65ri board to embed TF-M in the SoC
secure world.

The flash layout is synced with the layout defined in Zephyr TF-M
integration of platform STM32WBA65I.

- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
shrutig-arm
shrutig-arm reviewed Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@shrutig-arm shrutig-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update with correct copyright year for all the files.

@ahmadstm ahmadstm force-pushed the stm32wba6_psa_api branch from 7c78575 to ebda84e Compare June 2, 2025 12:55
@ahmadstm
Copy link
Contributor Author

ahmadstm commented Jun 2, 2025

update copyright : Done.

shrutig-arm
shrutig-arm reviewed Jun 3, 2025
View reviewed changes
api-tests/platform/drivers/watchdog/stm/pal_wd_stm.c Outdated
@@ -1,5 +1,5 @@
/** @file
* Copyright (c) 2018-2019, Arm Limited or its affiliates. All rights reserved.
* Copyright (c) 2021 - 2025, STMicroelectronics.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier copyright year was 2018-2019. You can mention it now as 2018-2025.

shrutig-arm
shrutig-arm reviewed Jun 3, 2025
View reviewed changes
api-tests/platform/drivers/watchdog/stm/pal_wd_stm.h Outdated
@@ -1,5 +1,5 @@
/** @file
* Copyright (c) 2018-2019, Arm Limited or its affiliates. All rights reserved.
* Copyright (c) 2021 - 2025, STMicroelectronics.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as pal_wd_stm.c

shrutig-arm
shrutig-arm reviewed Jun 3, 2025
View reviewed changes
api-tests/platform/targets/tgt_dev_apis_tfm_stm32wba/nspe/pal_attestation_config.h
@@ -0,0 +1,107 @@
/** @file
* Copyright (c) 2025, STMicroelectronics.
* SPDX-License-Identifier : Apache-2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright as
/** @file
* Copyright (c) 2025, Arm Limited or its affiliates. All rights reserved.
* SPDX-License-Identifier : Apache-2.0
*
* Copyright (c) 2025, STMicroelectronics.
* SPDX-License-Identifier : Apache-2.0

Please keep Arm in the copyright mentions and you can add STMicroelectronics below as mentioned here. Please consider the same for other files.

shrutig-arm
shrutig-arm reviewed Jun 3, 2025
View reviewed changes
api-tests/platform/targets/tgt_dev_apis_tfm_stm32wba/target_database.h
@@ -0,0 +1,53 @@
#ifndef _TARGET_DATABASE_H_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add copyright for this file.

ahmadstm added 2 commits June 3, 2025 09:35
@ahmadstm
ST : Add STM32WBA platform to psa-arch-tests.
b50fcf3 
Change-Id: Ic7947b7f0cc1d922295f6a21539915e402229c9f
Signed-off-by: Ahmad EL JOUAID <ahmad.eljouaid@st.com>
@ahmadstm
Merge pull request #4 from ARM-software/main
874b8c2 
update copyright : done
@shrutig-arm shrutig-arm merged commit 10b92ad into ARM-software:main Jun 3, 2025
etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request Jun 4, 2025
@etienne-lms
boards: st: stm32wba65i_dk1: Add ns variant for TF-M support
941127d 
Add variant ns to stm32wba65i_dk1 board to embed TF-M in the SoC
secure world. The flash layout is synced with the layout defined
in Zephyr TF-M integration of platform STM32WBA65I.

Successfully tested against a few samples and test samples:
- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request Jun 4, 2025
@etienne-lms
boards: st: nucleo_wba65ri: Add ns variant for TF-M support
11ac7c5 
Add variant ns to nucleo_wba65ri board to embed TF-M in the SoC
secure world.

The flash layout is synced with the layout defined in Zephyr TF-M
integration of platform STM32WBA65I.

- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request Jun 5, 2025
@etienne-lms
boards: st: stm32wba65i_dk1: Add ns variant for TF-M support
1c57f47 
Add variant ns to stm32wba65i_dk1 board to embed TF-M in the SoC
secure world. The flash layout is synced with the layout defined
in Zephyr TF-M integration of platform STM32WBA65I.

Successfully tested against a few samples and test samples:
- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
etienne-lms added a commit to etienne-lms/zephyr that referenced this pull request Jun 5, 2025
@etienne-lms
boards: st: nucleo_wba65ri: Add ns variant for TF-M support
d5cdfba 
Add variant ns to nucleo_wba65ri board to embed TF-M in the SoC
secure world.

The flash layout is synced with the layout defined in Zephyr TF-M
integration of platform STM32WBA65I.

- samples/tfm_integration/psa_crypto
- samples/tfm_integration/psa_protected_storage
- samples/tfm_integration/tfm_ipc
- samples/tfm_integration/tfm_secure_partition
- tests/subsys/secure_storage/psa/crypto
- tests/subsys/secure_storage/psa/its
  (with CONFIG_TFM_ITS_MAX_ASSET_SIZE_OVERRIDE=y
  and CONFIG_TFM_ITS_MAX_ASSET_SIZE=256)

There is currently a build issue that prevents to build (and run)
samples/tfm_integration/tfm_regression_test when using GCC 11.x or 12.x.
The issue needs should be addressed in TF-M with a change like the
one applied on STM32U5 platforms, see [1] and [2].

Support for PSA Arch Tests (samples/tfm_integration/tfm_psa_test) in
not yet merged but is in under review [3].

Link: zephyrproject-rtos/trusted-firmware-m@edbb015 [1]
Link: TrustedFirmware-M/trusted-firmware-m@578a6f4 [2]
Link: ARM-software/psa-arch-tests#406 [3]
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutig-arm shrutig-arm shrutig-arm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadstm @shrutig-arm