Removing duration for mpg movies calculation. #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have fixed this. Added duration keyword for movie generatoin to allow setting in case moviepy gets it wrong.
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
zssherman
approved these changes
May 15, 2025
AdamTheisen
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing duration calculation for mpg movies calculation. moviepy 2.* appears to have fixed this. Added duration keyword for movie generation to allow setting in case moviepy gets it wrong. Added additional check for moviepy version since that is now required for duration setting.