Skip to content

ADD: Adding ameriflux discovery module. This module is based on the R code amerifluxr #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 21, 2025

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Apr 2, 2025

  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@zssherman
Copy link
Collaborator Author

Note, I still need to add tests and examples

@zssherman
Copy link
Collaborator Author

@AdamTheisen Should we leave the default to agree_policy False? So users read the policy first? I was debating how to approach that...

@AdamTheisen
Copy link
Collaborator

@zssherman I didn't get a chance to review today but blocking my calendar Wed afternoon

@zssherman
Copy link
Collaborator Author

@AdamTheisen no worries!

@zssherman
Copy link
Collaborator Author

zssherman commented Apr 9, 2025

@AdamTheisen I did changes to address your comments. Let me know if the recent commit looks good for all your comments. For the is test I add a kwargs, but once we have the seceret email and username added, ill add one more check to the is test. That way we keep that hidden, but still available for our unit tests

@zssherman
Copy link
Collaborator Author

@AdamTheisen Added the new reader, ready for review when folks have time. Working on the tests still though

Copy link
Collaborator

@AdamTheisen AdamTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zssherman I cc'd you in on the email from the AmeriFlux developers and I think you hit all their requirements. I think this is looking good as well once we get the tests working!

@zssherman zssherman closed this May 5, 2025
@zssherman zssherman reopened this May 5, 2025
@zssherman zssherman closed this May 13, 2025
@zssherman zssherman reopened this May 13, 2025
@zssherman zssherman merged commit cd8bd8a into ARM-DOE:main May 21, 2025
30 of 40 checks passed
@zssherman zssherman deleted the ameriflux_add branch May 28, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants