Skip to content

Conversation

@4555jan
Copy link
Contributor

@4555jan 4555jan commented Oct 15, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Changes made:

  • it just a small change the error causeing keyword late just removed it
  • Removed fromuserAddedSubscription` field declaration
  • fields are now properly nullable and use null-safe operators (?.)

Fixes #560

Type of change

  • Bug fix (non-breaking CHANGE which fixes an issue)

How Has This Been Tested?

Tested the pairing flow:

  1. Started quick match/choose partner
  2. Canceled the request before pairing
  3. Verified no crash occurs
  4. Confirmed the app returns to home screen properly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@github-actions
Copy link
Contributor

🎉 Welcome @4555jan!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@M4dhav M4dhav self-requested a review October 18, 2025 11:57
@M4dhav M4dhav added the bug Something isn't working label Oct 18, 2025
@M4dhav
Copy link
Contributor

M4dhav commented Oct 18, 2025

The "Changes Made" mentions

fields are now properly nullable and use null-safe operators (?.)

However the only change seems to be the removal of the late operator. Please confirm this and also confirm if you have verified all Pair Chat functionalities to be working

@4555jan
Copy link
Contributor Author

4555jan commented Oct 18, 2025

Yes, the main change was the removal of the late keyword for userAddedSubscription. These fields were already declared as nullable (RealtimeSubscription?), and the code was already using null-safe calls (like ?.close()), so no further change to null-safety operators was necessary. The reason this change was needed is that using late with nullable fields caused a LateInitializationError when calling .close() before initialization. Removing late ensures they are properly initialized to null, allowing the existing ?. calls to safely handle them. @M4dhav if you want i can make video before and after to show how i tested

@M4dhav
Copy link
Contributor

M4dhav commented Oct 18, 2025

A video is not necessary. Thank you for the contribution!

@M4dhav M4dhav merged commit bd242cb into AOSSIE-Org:dev Oct 18, 2025
3 checks passed
@github-actions
Copy link
Contributor

PR Closed - Thank You, @4555jan!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LateInitializationError in PairChatController (userAddedSubscription not initialized)

2 participants