Skip to content

Conversation

@Mayank4352
Copy link
Contributor

@Mayank4352 Mayank4352 commented Oct 6, 2025

Description

Currently, after creating a room, there is no option to delete it from the UI. Users should have the ability to remove rooms they no longer need.

Fixes #446

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested Locally

WhatsApp.Video.2025-10-06.at.17.12.58_49cd4753.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🎉 Welcome @Mayank4352!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mayank4352 Mayank4352 changed the title Tester Added the Functionality to remove the rooms Oct 6, 2025
@M4dhav M4dhav self-requested a review October 13, 2025 18:45
@M4dhav M4dhav added the enhancement New feature or request label Oct 13, 2025
@M4dhav M4dhav linked an issue Oct 13, 2025 that may be closed by this pull request
@M4dhav
Copy link
Contributor

M4dhav commented Oct 13, 2025

Hey @Mayank4352 , let's change the UI as bit, lets swap the positions of the delete and chat button, as we should ensure that user's won't accidentally press the delete button. Yes, there's another dialog to confirm, but still let's swap the positions. Also, please ensure the button looks good across all color themes.

@Mayank4352
Copy link
Contributor Author

Sure, will do

Copy link
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make suggested UI Changes

@Mayank4352
Copy link
Contributor Author

WhatsApp Image 2025-10-14 at 12 09 21_bff908da
WhatsApp Image 2025-10-14 at 12 09 20_db2e7428
WhatsApp Image 2025-10-14 at 12 09 21_e6a6dd5e

WhatsApp Image 2025-10-14 at 12 09 21_06276433

Yes, the icon looks good across all the themes, also i have adjusted the size for the Floating action button for the chat window to match the size of Subscribe button for uniformity

@Mayank4352 Mayank4352 requested a review from M4dhav October 14, 2025 06:43
@M4dhav
Copy link
Contributor

M4dhav commented Oct 14, 2025

So just to confirm, this functionality is for an attendee and not the host, right?

@Mayank4352
Copy link
Contributor Author

Mayank4352 commented Oct 14, 2025

Yes

@4555jan
Copy link
Contributor

4555jan commented Oct 28, 2025

@M4dhav is this still open

@Mayank4352
Copy link
Contributor Author

Fix what?

@4555jan
Copy link
Contributor

4555jan commented Oct 28, 2025

@Mayank4352 it isnt merged yet so i thought may be it is still open sorry

@Mayank4352
Copy link
Contributor Author

No worries, he’s probably been busy and hasn’t gotten the chance to review it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Option to Delete Created Rooms

3 participants