BUG: label_geometry_measures with uint32 labels #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To save an unnecessary clone, we were lazily cloning the data but if the labels are actually uint32, the variable wasn't properly initialized. For label_stats, add checks that labels are unsigned. Also re-index data in the returned DF by label - it was previously sorted by label, but the pandas index was not updated
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to handling uint32 labels in label geometry measures and improves the label_stats function. The main issue was that when labels were already uint32, a variable wasn't properly initialized, causing potential failures.
- Fixes variable initialization bug when labels are already uint32 in label_geometry_measures
- Adds validation checks to ensure labels can be represented as uint32 in both functions
- Updates label_stats to properly reset DataFrame index after sorting
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/labelStats.cxx | Changes vector types from double to LabelType for labelvals and counts arrays |
| ants/label/label_stats.py | Adds uint32 validation checks and fixes DataFrame index after sorting |
| ants/label/label_geometry_measures.py | Fixes uninitialized variable bug when labels are already uint32 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save an unnecessary clone, we were lazily cloning the data but if the labels are actually uint32, the variable wasn't properly initialized.
For label_stats, add checks that labels are unsigned. Also re-index data in the returned DF by label - it was previously sorted by label, but the pandas index was not updated, so a merge on index would be wrong