Benchmark improvements #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table showing the results for the different facilities had a column named "Type", which in the case of the jsonslicer tests corresponded to the text type of the produced output. To clarify this I've changed the name to "Output type", and also removed the information redundancy in the jsonslicer test case names, where the output type was mentioned too. I have also corrected the output type for the ijson tests, as ijson always outputs str. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This change brings all the assertion code together into a common function that all test cases use. This way it's easier to add new assertions. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
The latter always take paths as str, not as bytes, and no internal check is done (yet) to double-check this. As a result the comparisons with ijson were bogus, as ijson.items was yielding no results (with python 3.8.2; in python 2.7 they would have yielded the correct results, but jsonslicer doesn't support 2.7). To avoid bogus comparisons in the future a new assertion in the common assertion code now verifies that the expected number of objects were yielded by the different methods. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the benchmarking code. Please check each commit message for further explanation and better breakup of the changes.