Forkserver: Add __AFL_SHM_FUZZ_MAP_SIZE, clean up env variables #3235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
May 15, 2025
There was a problem hiding this comment.
I didn't. Is it in gitignore?
There was a problem hiding this comment.
all .lock files are in gitignore, but it is about un-committed files, i guess. for this one, we already committed so any change to it on your side is reflected
There was a problem hiding this comment.
Nope we totally need to have no checked in files ignored in the gitignore else... well this happens
There was a problem hiding this comment.
Allowed Cargo.lock for all fuzzers now, because it makes sense
This was referenced May 15, 2025
Closed
|
Waiting for AFLplusplus/AFLplusplus#2430 |
domenukk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
__AFL_SHM_FUZZ_MAP_SIZEenv for the forkserver target (to know about the input page size) - as discussed in #3229Checklist
./scripts/precommit.shand addressed all comments