Use a formatter to display Btc/MilliBtc amounts
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display a fixed number of digits after the comma, instead of the default which may even use the exponent display occasionnally. Please double check the `MilliBtc` case as it's easy to get it wrong.
sstone
requested changes
Feb 11, 2025
|
Totally! Done in f275ea5. Note that I hardcoded the locale to Also, I switched to at most 8 decimals instead of always 8 decimals (1.2345 instead of 1.23450000). I think it's more readable. |
sstone
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display at most 8 decimals, instead of the default which may even use the exponent display occasionnally.
Please double check the
MilliBtccase as it's easy to get it wrong.