Add back variants after Prerelease Root Spec modifications #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
added
type:bug
priority:high
version:MINOR
…e, include the variants as well
CodeGat
force-pushed
the
260-prerelease-root-spec-variants
branch
from
c761b82 to
f041850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
Background
When we are doing our prerelease modifications, we replace the root spec with only the root spec name (removing any
@git.VERSIONas required), but we don't add back any variants that may have been in the original root spec definition. More details are in the linked issue.In this PR, we do our replacements a bit more carefully - so if the original spec was
access-om2@git.2025.03.0 +debug, the replaced spec would beaccess-om2 +debugrather thanaccess-om2.The PR
Testing
regex101- https://regex101.com/r/AujFTw/1