Skip to content

Update ocean field table based on ocean spinup run #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

blimlim
Copy link

@blimlim blimlim commented Apr 2, 2025

Closes #81
This pull request adds @pearseb's updated ocean field_table to the preindustrial configuration. This field table comes from the long spinup run.

@pearseb, do you know which years of the spinup run this table was used for?

@blimlim
Copy link
Author

blimlim commented Apr 2, 2025

!test repro commit

Copy link

github-actions bot commented Apr 2, 2025

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 81-update-field-table (checksums created using commit 92d6721), against
  • dev-preindustrial+concentrations (checksums in commit 2e3a27c)

🔧 The new checksums will be committed to this PR, if they differ from what is on this branch.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-esm1.6-configs/92d6721741cbc29dda036e56cbf72519e0b87469, and the test results at https://github.com/ACCESS-NRI/access-esm1.6-configs/runs/39822380485.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-esm1.6-configs/actions/runs/14212400617/artifacts/2864866721.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/2e3a27ce1a16711a318cb13cc1b377338d4ae096/testing/checksum

@blimlim
Copy link
Author

blimlim commented Apr 9, 2025

Thanks @pearseb! I've just added those changes in b418c09 and pinged you for a re-review!

@blimlim blimlim requested a review from pearseb April 9, 2025 01:56
Copy link

@pearseb pearseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Spencer and sorry for taking a few days to get to this. I'm actually still waiting on my optimisation routines to provide the best values. Give me until the afternoon.

@pearseb
Copy link

pearseb commented Apr 9, 2025

Actually, just go for it Spencer... the optimisation is running into a few road blocks...

@pearseb pearseb closed this Apr 9, 2025
@pearseb pearseb reopened this Apr 9, 2025
Copy link

@pearseb pearseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@pearseb pearseb merged commit e17bd64 into dev-preindustrial+concentrations Apr 9, 2025
21 checks passed
@blimlim
Copy link
Author

blimlim commented Apr 9, 2025

Perfect, thanks @pearseb!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants