Skip to content

Update 8hobbies/workflows digest to 35aaff6 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

Update 8hobbies/workflows digest to 35aaff6 #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@35aaff65a539af824d36a72aac42393a71092cc9

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix the detected issue, you should add the permissions key to the workflow definition (.github/workflows/lint.yml) at the root level (above jobs), unless jobs require specific permissions. As the lint job appears to perform only linting, it is likely sufficient to set contents: read. Place the permissions: block immediately after the workflow name: and before on:, as recommended by GitHub best practices. No additional imports, definitions, or methods are needed; the only change is the YAML block addition.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -13,6 +13,8 @@
 # limitations under the License.
 
 name: Lint
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -13,6 +13,8 @@
# limitations under the License.

name: Lint
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
permissions:
pages: write
id-token: write
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@35aaff65a539af824d36a72aac42393a71092cc9
2 changes: 1 addition & 1 deletion .github/workflows/publish-dry-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@35aaff65a539af824d36a72aac42393a71092cc9

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To address this issue, you should add a permissions block to either the top level of .github/workflows/publish-dry-run.yml or to the specific job under jobs:. Since there is only a single job (run:), the recommended approach is to place the permissions key at the top level of the workflow file, just after the name: and before on:. This limits the permissions of GITHUB_TOKEN for the entire workflow unless overridden by a job. As a minimal starting point, use permissions: {} to fully restrict all default permissions. If your workflow requires specific permissions (for example, contents: read for fetching code), set only those that are necessary for the workflow to function. In this case, since the workflow delegates all functionality to a reusable workflow, it is safest to start with the most restrictive block {} and incrementally add needed permissions if jobs fail due to lack of access.

Suggested changeset 1
.github/workflows/publish-dry-run.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/publish-dry-run.yml b/.github/workflows/publish-dry-run.yml
--- a/.github/workflows/publish-dry-run.yml
+++ b/.github/workflows/publish-dry-run.yml
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 name: Publish Dry Run
+permissions: {}
 
 on:
   push:
EOF
@@ -13,6 +13,7 @@
# limitations under the License.

name: Publish Dry Run
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
tags: ["v*"]
jobs:
build:
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@35aaff65a539af824d36a72aac42393a71092cc9
secrets:
npm-auth-token: ${{ secrets.NPM_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@35aaff65a539af824d36a72aac42393a71092cc9

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix this issue, we should explicitly add a permissions: block to the workflow file, .github/workflows/runtime.yml, either at the root (which then applies to all jobs) or for the specific job (in this case, the only job is test). Because this workflow only delegates to a reusable workflow (uses), and unless we know more about what specific permissions are required, we should set contents: read as the minimal safe default. If additional permissions (such as pull-requests: write) are required by the reusable workflow, those should also be listed, but starting with the minimal case is appropriate. The edit is to insert a permissions: block at the top level, immediately below name: Runtime.

Suggested changeset 1
.github/workflows/runtime.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/runtime.yml b/.github/workflows/runtime.yml
--- a/.github/workflows/runtime.yml
+++ b/.github/workflows/runtime.yml
@@ -13,6 +13,8 @@
 # limitations under the License.
 
 name: Runtime
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -13,6 +13,8 @@
# limitations under the License.

name: Runtime
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.