Fix/improved pagination #50
Merged
+159
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed `limit` parameter from `fetchPostData` in `IHomeRepository` and `HomeRepository`. - Updated `makeFetchPostsRequest` to use `ApiEndpoints.pageSize` for the `_limit` query parameter. - In `HomeBloc`, removed `_page` and `_limit` variables. - Refactored `_fetchPosts` and `_onLoadMorePosts` to utilize the new `fetchPostData` signature. - Modified `HomeState` to calculate `nextPage` based on `postList.length` and `ApiEndpoints.pageSize`. - Added `pageSize` constant in `ApiEndpoints`. - Improved the code comments in `HomeState` related to the calculation of `nextPage`
- Documented that `nextPage` calculation depends on whether API pagination starts with 0 or 1. - Added examples for both scenarios.
- Added `firebase_app_distribution.sh` script to automate APK distribution to Firebase App Distribution. - The script builds the APK, prompts for group name and release notes, then uploads it to Firebase. - The script reads the `appId` from `firebase_options.dart` to use it in firebase distribution. - Included error handling for missing `firebase_options.dart` and empty group name. - Included a default release notes in case user doesn't enter any.
…Actions - Added a workflow to distribute the production Android APK to Firebase App Distribution. - Installed the Firebase CLI in the workflow. - Extracted the Firebase App ID from `firebase_options.dart`. - Configured distribution to the "7Span-Internal" group. - Included the commit message as release notes. - Set up `FIREBASE_TOKEN` as an environment variable.
- Added `fix/improved-pagination` to the list of branches that trigger the workflow.
- Removed the step that extracted the Firebase App ID from `firebase_options.dart` in the CI workflow. - Replaced the extracted App ID with a `FIREBASE_APP_ID` secret for distributing the APK to Firebase App Distribution.
- Removed the `fix/improved-pagination` branch from the list of branches that trigger the workflow.
- Added a new job step to upload iOS IPA files to App Store Connect. - Created a new step to build iOS IPA. - Created a new step to store the App Store Connect API key file. - Updated the Firebase App Distribution script to use the `app-prod-release.apk` file. - Added the `fix/improved-pagination` branch to the list of branches that trigger the workflow.
- Added `--flavor prod` to the `flutter build ipa` command for building the iOS IPA.
- Modified project settings to update `PRODUCT_BUNDLE_IDENTIFIER` to "com.flutter.boilerplate.demo.app". - Added empty `inputPaths` and `outputPaths` for Copy Pods Resources and Embed Pods Frameworks.
- Updated app icons for the app - Fixed `PRODUCT_BUNDLE_IDENTIFIER` in the project file to be consistent. - Updated project files to remove unused input and output paths.
- Added `ExportOptions.plist` for configuring iOS app store export options. - Updated iOS build command in `main.yml` to use the new `ExportOptions.plist` file. - Commented out the code that related to the Android in `main.yml`.
- Removed `fix/improved-pagination` branch from the trigger events. - Uncommented and reordered steps for building and distributing Android APK. - Added steps for accepting Android SDK licenses and installing NDK. - Added steps for building Android APK and distributing it via Firebase. - Added step for Upload the build Artifact. - Removed iOS TestFlight upload steps.
cavin-7span
reviewed
Apr 30, 2025
cavin-7span
requested changes
Apr 30, 2025
- Moved `pageSize` from `ApiEndpoints` to `ApiConstant`. - Updated all references of page size to use `ApiConstant.pageSize`. - Added `ApiConstant` into `api_client` package export.
cavin-7span
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved pagination for page count
Added Firebase distribution in Local script and CI/CD workflow
Type of Change
#49