Skip to content

Fix Typo in AssistantStreamEvent Variant (TreadCreatedThreadCreated) #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

posky
Copy link

@posky posky commented Jul 1, 2025

Pull Request: Fix Typo in AssistantStreamEvent Variant

Summary

This PR fixes a typo in the AssistantStreamEvent enum:
Renames TreadCreated to ThreadCreated for better consistency and readability.


Changes

  • Enum Variant Renamed

    • Before: TreadCreated(ThreadObject)
    • After: ThreadCreated(ThreadObject)
  • Event Handling Updated

    • The match arm for the "thread.created" event now uses AssistantStreamEvent::ThreadCreated instead of the misspelled variant.

Motivation

  • Consistency & Readability
    The previous variant name TreadCreated was a typo and did not match the intended naming convention. This change ensures the code is self-explanatory and maintains consistent terminology.
  • Maintainability
    Fixing typos in public APIs and enums helps prevent confusion and potential bugs in the future.

Impact

  • All usages of AssistantStreamEvent::TreadCreated should be updated to AssistantStreamEvent::ThreadCreated.
  • No functional changes were made; this is strictly a naming correction.

Reference

-    TreadCreated(ThreadObject),
+    ThreadCreated(ThreadObject),

BREAKING CHANGES: changed AssistantStreamEvent filed name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant