FIX: Removed unnecessary warn logs that are part of the login flow #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved unused constructor
|
sptdevos
approved these changes
Apr 24, 2025
| super(msg); | ||
| } | ||
|
|
||
| public MfaRequiredException(String msg, Throwable cause) { |
There was a problem hiding this comment.
Deze constructor wordt toch niet gebruikt? Kan eventueel ook gewoon direct van RuntimeException erven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary WARN logs that have to do with the login flow.
Added 2 checks to the LogUtil:
When this is the case we want to debug it, not log a warning, since they are a normal part of the log in flow