Skip to content

charts - fix plotly 6.1.1 requirements #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Conversation

NomakCooper
Copy link
Contributor

SUMMARY

This PR removes charts module and install_dep role version restriction for plotly package.

charts module works correctly with plotly < 6.1.0 >= 6.1.1

Fixes #190

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

charts

ADDITIONAL INFORMATION

charts units and integration tests work fine

TASK [charts : Assert that all chart image files exist and are non-empty] ******
ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

Copy link

github-actions bot commented May 27, 2025

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here:
https://3A2DEV.github.io/ans2dev.general/pr/191

You can compare to the docs for the main branch here:
https://3A2DEV.github.io/ans2dev.general/branch/main

The docsite for this PR is also available for download as an artifact from this run:
https://github.com/3A2DEV/ans2dev.general/actions/runs/15281601011

File changes:

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/base/charts_module.html b/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/head/charts_module.html
index c63bcfc..9db3554 100644
--- a/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/base/charts_module.html
+++ b/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/head/charts_module.html
@@ -174,7 +174,7 @@ see <a class="reference internal" href="#ansible-collections-ans2dev-general-cha
 <p>The below requirements are needed on the host that executes this module.</p>
 <ul class="simple">
 <li><p>requests</p></li>
-<li><p>plotly &lt; 6.1.0</p></li>
+<li><p>plotly &lt; 6.1.0 &gt;= 6.1.1</p></li>
 <li><p>kaleido</p></li>
 </ul>
 </section>

@ans2bot ans2bot bot added the success CI Check Pass label May 27, 2025
@NomakCooper
Copy link
Contributor Author

/unlabel needs_triage

@ans2bot ans2bot bot removed the needs_triage label May 27, 2025
@NomakCooper
Copy link
Contributor Author

/label backport-10

@ans2bot ans2bot bot added the backport-10 backport to stable-10 label May 27, 2025
Copy link
Contributor Author

@NomakCooper NomakCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ans2bot ans2bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved by @NomakCooper

@NomakCooper NomakCooper merged commit a09d320 into 3A2DEV:main May 27, 2025
32 checks passed
Copy link
Contributor

patchback bot commented May 27, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/a09d320b740ee829e4fb94a765421be7b46362f7/pr-191

Backported as #192

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 27, 2025
* charts - fix plotly 6.1.1 requirements

* charts - add new changelog fragments

(cherry picked from commit a09d320)
NomakCooper added a commit that referenced this pull request May 27, 2025
* charts - fix plotly 6.1.1 requirements

* charts - add new changelog fragments

(cherry picked from commit a09d320)

Co-authored-by: Nocchia <133043574+NomakCooper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 backport to stable-10 bug This issue/PR relates to a bug. docs_fragments module plugin roles success CI Check Pass tests units
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts - image generation not work with plotly 6.1.0
1 participant