-
Notifications
You must be signed in to change notification settings - Fork 1
charts - fix plotly 6.1.1 requirements #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs Build 📝Thank you for contribution!✨ The docs for this PR have been published here: You can compare to the docs for the The docsite for this PR is also available for download as an artifact from this run: File changes: Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/base/charts_module.html b/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/head/charts_module.html
index c63bcfc..9db3554 100644
--- a/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/base/charts_module.html
+++ b/home/runner/work/ans2dev.general/ans2dev.general/docsbuild/head/charts_module.html
@@ -174,7 +174,7 @@ see <a class="reference internal" href="#ansible-collections-ans2dev-general-cha
<p>The below requirements are needed on the host that executes this module.</p>
<ul class="simple">
<li><p>requests</p></li>
-<li><p>plotly < 6.1.0</p></li>
+<li><p>plotly < 6.1.0 >= 6.1.1</p></li>
<li><p>kaleido</p></li>
</ul>
</section>
|
/unlabel needs_triage |
/label backport-10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved by @NomakCooper
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #192 🤖 @patchback |
* charts - fix plotly 6.1.1 requirements * charts - add new changelog fragments (cherry picked from commit a09d320)
SUMMARY
This PR removes
charts
module andinstall_dep
role version restriction forplotly
package.charts module works correctly with
plotly
<6.1.0
>=6.1.1
Fixes #190
ISSUE TYPE
COMPONENT NAME
charts
ADDITIONAL INFORMATION
charts units and integration tests work fine