fix: add helm chart #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Vallecilla <andresfelipe083195@hotmail.com>
Signed-off-by: Andres Vallecilla <andresfelipe083195@hotmail.com>
Signed-off-by: Andres Vallecilla <andresfelipe083195@hotmail.com>
Signed-off-by: Andres Vallecilla <andresfelipe083195@hotmail.com>
…ic and updated docs Signed-off-by: Gabriel Mata <gabrielmatau@gmail.com>
Contributor
|
Hi @lotharking and @genaris 👋 I’ve improved the Helm chart by adding better handling for appCheckProxy:
Let me know your thoughts |
Signed-off-by: Gabriel Mata <gabrielmatau@gmail.com>
Signed-off-by: Gabriel Mata <gabrielmatau@gmail.com>
lotharking
commented
Jun 24, 2025
Signed-off-by: Gabriel Mata <gabrielmatau@gmail.com>
genaris
requested changes
Jun 25, 2025
Member
genaris
left a comment
genaris
left a comment
There was a problem hiding this comment.
Some minor comments, especially about publishing Docker image
lotharking
commented
Jun 25, 2025
Co-authored-by: Ariel Gentile <gentilester@gmail.com>
Co-authored-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Gabriel Mata <gabrielmatau@gmail.com>
Contributor
|
@genaris @lotharking, All changes ready mates! please check and let me know ... |
genaris
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.