feat: 스크롤 인디케이터 추가 #135
feat: 스크롤 인디케이터 추가 #135
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hyonun321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the user experience of the homepage by adding a clear, animated scroll indicator to the introduction section. This visual cue guides users to discover further content, improving overall engagement and navigation on the page.
Highlights
- New Feature: Scroll Indicator: This pull request introduces an animated scroll indicator to the
Introductioncomponent, providing a visual cue for users to scroll down and explore more content. - Enhanced User Experience: The addition of the scroll indicator aims to improve user guidance and content discoverability on the homepage, making the interaction more intuitive.
- UI Implementation Details: The scroll indicator is implemented using
framer-motionfor its animation capabilities and styled withtailwind-cssfor a responsive and modern appearance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| {/* 스크롤 안내 애니메이션 */} | ||
| <motion.div | ||
| initial={{ opacity: 0, y: 20 }} | ||
| animate={{ opacity: 1, y: 0 }} | ||
| transition={{ delay: 1.5, duration: 0.8 }} | ||
| className="mt-8" | ||
| > | ||
| <motion.div | ||
| animate={{ y: [0, 10, 0] }} | ||
| transition={{ | ||
| duration: 2, | ||
| repeat: Infinity, | ||
| ease: 'easeInOut', | ||
| }} | ||
| className="flex flex-col items-center text-gray-600 dark:text-gray-400" | ||
| > | ||
| <span className="text-sm font-medium mb-2"> | ||
| 스크롤하여 더 알아보기 | ||
| </span> | ||
| <motion.div | ||
| animate={{ y: [0, 8, 0] }} | ||
| transition={{ | ||
| duration: 1.5, | ||
| repeat: Infinity, | ||
| ease: 'easeInOut', | ||
| }} | ||
| className="w-6 h-10 border-2 border-gray-400 dark:border-gray-500 rounded-full flex justify-center" | ||
| > | ||
| <motion.div | ||
| animate={{ y: [0, 12, 0] }} | ||
| transition={{ | ||
| duration: 1.5, | ||
| repeat: Infinity, | ||
| ease: 'easeInOut', | ||
| }} | ||
| className="w-1 h-3 bg-gray-400 dark:bg-gray-500 rounded-full mt-2" | ||
| /> | ||
| </motion.div> | ||
| </motion.div> | ||
| </motion.div> |
There was a problem hiding this comment.
스크롤 안내 애니메이션 로직이 Introduction 컴포넌트 내부에 직접 작성되어 있어 가독성과 유지보수성을 저해할 수 있습니다. Introduction 컴포넌트는 이미 크기가 크기 때문에, 이 부분을 별도의 ScrollIndicator 컴포넌트로 분리하는 것을 강력히 권장합니다. 이렇게 하면 코드가 더 모듈화되고 재사용이 용이해집니다.1 컴포넌트명은 ScrollIndicator2, 파일명은 scroll-indicator.tsx3로 명명하는 것이 스타일 가이드에 부합합니다.
또한, 애니메이션에 사용된 수치들(magic numbers)을 상수로 정의하면 코드의 의도를 더 명확하게 파악할 수 있습니다.4
아래는 리팩토링 예시입니다.
ScrollIndicator 컴포넌트 (예: app/home/components/scroll-indicator.tsx에 생성)
import { motion } from 'framer-motion';
// 애니메이션 속성을 상수로 정의하여 가독성 및 유지보수성 향상
const SCROLL_INDICATOR_ANIMATION = {
WRAPPER: {
initial: { opacity: 0, y: 20 },
animate: { opacity: 1, y: 0 },
transition: { delay: 1.5, duration: 0.8 },
},
GROUP: {
animate: { y: [0, 10, 0] },
transition: { duration: 2, repeat: Infinity, ease: 'easeInOut' },
},
MOUSE_OUTLINE: {
animate: { y: [0, 8, 0] },
transition: { duration: 1.5, repeat: Infinity, ease: 'easeInOut' },
},
MOUSE_WHEEL: {
animate: { y: [0, 12, 0] },
transition: { duration: 1.5, repeat: Infinity, ease: 'easeInOut' },
},
};
const ScrollIndicator = () => (
<motion.div
{...SCROLL_INDICATOR_ANIMATION.WRAPPER}
className="mt-8"
>
<motion.div
{...SCROLL_INDICATOR_ANIMATION.GROUP}
className="flex flex-col items-center text-gray-600 dark:text-gray-400"
>
<span className="text-sm font-medium mb-2">
스크롤하여 더 알아보기
</span>
<motion.div
{...SCROLL_INDICATOR_ANIMATION.MOUSE_OUTLINE}
className="w-6 h-10 border-2 border-gray-400 dark:border-gray-500 rounded-full flex justify-center"
>
<motion.div
{...SCROLL_INDICATOR_ANIMATION.MOUSE_WHEEL}
className="w-1 h-3 bg-gray-400 dark:bg-gray-500 rounded-full mt-2"
/>
</motion.div>
</motion.div>
</motion.div>
);
export default ScrollIndicator;Introduction.tsx 에서 사용법
import ScrollIndicator from './scroll-indicator'; // 경로에 맞게 수정
// ...
</h1>
{/* 스크롤 안내 애니메이션 */}
<ScrollIndicator />
// ...Style Guide References
Footnotes
3 participants
📝 변경 사항
🔍 변경 사항 세부 설명
🕵️♀️ 요청사항
📷 스크린샷 (선택)