-
Couldn't load subscription status.
- Fork 3
Feat 홈페이지 배너 변경 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 홈페이지 배너 변경 #115
The head ref may contain hidden characters: "feat-\uD648\uD398\uC774\uC9C0-\uBC30\uB108-\uBCC0\uACBD"
Conversation
…into feat-홈페이지-배너-변경
- 스크롤 생겨서 늘림
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hyonun321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the homepage banner with a new design that includes an animation, and I've also fixed an issue where text was not displaying correctly in dark mode for certain elements. Additionally, I've refined the logic for managing data item cards and made some minor UI adjustments across the application.
Highlights
- Homepage Banner Redesign: Implemented a dynamic and animated banner on the homepage, replacing the previous static image to enhance user engagement.
- Dark Mode Text Visibility Fix: Resolved a display issue where certain text elements, specifically nicknames in the favorite list modal, were not visible in dark mode.
- Enhanced Data Item Card Management: Improved the functionality of edit and delete buttons on data item cards, ensuring these actions are appropriately restricted to 'SELL' category items and providing clearer user feedback.
- Minor UI/UX Refinements: Applied subtle styling adjustments to components like the filter sidebar and price unit toggle, and added a convenient "Register Post" button to the home layout for improved usability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정말 수고많으셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
홈페이지 배너 디자인을 새롭게 변경하고 단골 목록의 다크모드 UI를 개선하는 PR이네요. 전체적으로 변경 사항은 좋아 보입니다. 몇 가지 코드 가독성 및 유지보수성 향상을 위한 제안과 스타일 가이드 위반 사항을 수정하는 코멘트를 남겼습니다. 특히 새로 추가된 애니메이션 컴포넌트의 경우, 매직 넘버를 상수로 대체하고 파일명을 스타일 가이드에 맞게 수정하면 더 좋은 코드가 될 것 같습니다.
| {/* <Image | ||
| src="/potato-lime.png" | ||
| alt="메인 배너 이미지" | ||
| fill | ||
| className="object-contain" | ||
| priority | ||
| /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import React from 'react'; | ||
| import { useMediaQuery } from '@/app/(shared)/hooks/useMediaQuery'; | ||
|
|
||
| export default function UserConnectionAnimation({ className = '' }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
디자인 쉽지않네
📝 변경 사항
🔍 변경 사항 세부 설명
🕵️♀️ 요청사항
📷 스크린샷 (선택)