Skip to content

Conversation

@hyonun321
Copy link
Contributor

📝 변경 사항

  1. 홈페이지 배너 디자인 변경
  2. 단골 다크모드 글자 미적용 반영

🔍 변경 사항 세부 설명

🕵️‍♀️ 요청사항

📷 스크린샷 (선택)

image

@hyonun321 hyonun321 self-assigned this Aug 5, 2025
@hyonun321 hyonun321 added the STYLE css 스타일 조정 label Aug 5, 2025
@github-actions github-actions bot enabled auto-merge August 5, 2025 12:16
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hyonun321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the homepage banner with a new design that includes an animation, and I've also fixed an issue where text was not displaying correctly in dark mode for certain elements. Additionally, I've refined the logic for managing data item cards and made some minor UI adjustments across the application.

Highlights

  • Homepage Banner Redesign: Implemented a dynamic and animated banner on the homepage, replacing the previous static image to enhance user engagement.
  • Dark Mode Text Visibility Fix: Resolved a display issue where certain text elements, specifically nicknames in the favorite list modal, were not visible in dark mode.
  • Enhanced Data Item Card Management: Improved the functionality of edit and delete buttons on data item cards, ensuring these actions are appropriately restricted to 'SELL' category items and providing clearer user feedback.
  • Minor UI/UX Refinements: Applied subtle styling adjustments to components like the filter sidebar and price unit toggle, and added a convenient "Register Post" button to the home layout for improved usability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Collaborator

@yshls yshls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 수고많으셨습니다!

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

홈페이지 배너 디자인을 새롭게 변경하고 단골 목록의 다크모드 UI를 개선하는 PR이네요. 전체적으로 변경 사항은 좋아 보입니다. 몇 가지 코드 가독성 및 유지보수성 향상을 위한 제안과 스타일 가이드 위반 사항을 수정하는 코멘트를 남겼습니다. 특히 새로 추가된 애니메이션 컴포넌트의 경우, 매직 넘버를 상수로 대체하고 파일명을 스타일 가이드에 맞게 수정하면 더 좋은 코드가 될 것 같습니다.

Comment on lines +117 to +123
{/* <Image
src="/potato-lime.png"
alt="메인 배너 이미지"
fill
className="object-contain"
priority
/> */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

사용하지 않는 주석 처리된 코드가 남아있습니다. 코드의 혼란을 줄이고 가독성을 높이기 위해 제거하는 것이 좋습니다.

import React from 'react';
import { useMediaQuery } from '@/app/(shared)/hooks/useMediaQuery';

export default function UserConnectionAnimation({ className = '' }) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

스타일 가이드에 따라 파일명은 kebab-case를 사용해야 합니다.1 userConnectionAnimation.tsxuser-connection-animation.tsx로 변경하는 것을 권장합니다.

Style Guide References

Footnotes

  1. 파일명은 kebab-case를 사용해야 합니다. (e.g., user-profile.tsx) (link)

Copy link
Collaborator

@seungwoo505 seungwoo505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인 쉽지않네

@github-actions github-actions bot merged commit 5fa3403 into main Aug 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

STYLE css 스타일 조정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants