Skip to content

Conversation

Bloodmallet
Copy link

This PR contains the following changes for bootstrap modals:

  • variable names are consistently modal* now
  • added modalTitleId as id to the modal title (h5)
  • use modal id variable instead of "exampleModal"
  • indentation uses 4 spaces everywhere
  • deleted some indentations that were wrong

Thank you for this code addon. I hope this PR is deemed useful. After all I stumbled upon these issues when using it.

@Bloodmallet Bloodmallet changed the title fix variable names, fix indentation, add title id Fix some issues with bootstrap modals May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant