fix: handle try blocks without except clauses #3461
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by Nikita Fedkin.
Fixes BSL-LANGUAGE-SERVER-8Y. The issue was that:
CfgBuildingParseTreeVisitor
'svisitTryStatement
lacks a null check onexceptCodeBlock()
, causing aNullPointerException
when atry
statement lacks anexcept
block.CfgBuildingParseTreeVisitor
to handletry
blocks withoutexcept
clauses by creating a dummy exception block.tryWithoutExceptTest
toControlFlowGraphBuilderTest
to verify the correct handling oftry
blocks withoutexcept
clauses.testTryWithoutExcept
toAllFunctionPathMustHaveReturnDiagnosticTest
to ensure that the diagnostic check correctly handlestry
blocks withoutexcept
clauses.If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 30036.