Skip to content

fix: The dropdown data of subsequent nodes in the form cannot be displayed back #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

fix: The dropdown data of subsequent nodes in the form cannot be displayed back #3131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ui/src/workflow/nodes/form-node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,22 @@ class FormNode extends AppNode {
get_node_field_list() {
const result = []
const fields = this.props.model.properties?.config?.fields || []
let otherFields = []

try {
otherFields = this.props.model.properties.node_data.form_field_list.map((item: any) => ({
label: typeof item.label == 'string' ? item.label : item.label.label,
value: item.field
}))
this.props.model.properties.node_data.form_field_list.forEach((item: any) => {
if (!fields.some((f: any) => f.value === item.field)) {
fields.push({
value: item.field,
label: typeof item.label == 'string' ? item.label : item.label.label
})
}
})
} catch (e) {}
result.push({
value: this.props.model.id,
label: this.props.model.properties.stepName,
type: this.props.model.type,
children: [...fields, ...otherFields]
children: fields
})
return result
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a review of the provided code:

Issues:

  1. Redundancy: The otherFields array is created but not used within the scope where it's defined, leading to potential memory wastage.
  2. Simplification: Instead of mapping over form_field_list, you can use an arrow function directly. This reduces unnecessary steps.
  3. Type Checking: The code assumes that all properties have a non-null .properties object with nested objects. Ensure this assumption holds true.

Optimizations:

  1. Remove Unnecessary Variable Assignment: Since fields will be populated based on form_field_list, there’s no need to create otherFields.

Here's the revised code:

class FormNode extends AppNode {
  get_node_field_list() {
    const result = [];
    
    try {
      this.props.model.properties.node_data &&
      this.props.model.properties.node_data.form_field_list.length > 0 &&
      
      this.props.model.properties.node_data.form_field_list.forEach((item: any) => {
        // Check if the field already exists in fields
        if (!fields.includes(item.field)) {
          fields.push({
            value: item.field,
            label: typeof item.label == 'string' ? item.label : item.label.label
          });
        }
      });
      
    } catch (e) {}

    result.push({
      value: this.props.model.id,
      label: this.props.model.properties.stepName,
      type: this.props.model.type,
      children: fields || []
    });

    return result;
  }
}

This refactored version of your method should perform better and reduce memory usage without any functionality changes.

Expand Down