Skip to content

fix: The dropdown data of subsequent nodes in the form cannot be displayed back #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

fix: The dropdown data of subsequent nodes in the form cannot be displayed back #3129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ui/src/workflow/nodes/form-node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@ class FormNode extends AppNode {
constructor(props: any) {
super(props, FormNodeVue)
}
get_node_field_list() {
const result = []
const fields = this.props.model.properties?.config?.fields || []
let otherFields = []
try {
otherFields = this.props.model.properties.node_data.form_field_list.map((item: any) => ({
label: typeof item.label == 'string' ? item.label : item.label.label,
value: item.field
}))
} catch (e) {}
result.push({
value: this.props.model.id,
label: this.props.model.properties.stepName,
type: this.props.model.type,
children: [...fields, ...otherFields]
})
return result
}
}
export default {
type: 'form-node',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a couple of issues:

  1. Incorrect Constructor Call: The AppNodeVue import is missing from the constructor call (super()). It should be super(props, FormModel) where FormModel is assumed to be an alternative component that replaces FormNodeVue.

  2. Type Casting Issue: In JavaScript/TypeScript, you cannot directly assign a string property ('label') with another TypeScript object without explicit type casting. You can use parentheses around each assignment inside the map function.

  3. Return Type: The function signature indicates it returns an array but actually assigns results to variables instead before returning them. Consider modifying the logic to accumulate results in memory and then return once after all operations are completed.

Optimization Suggestions:

  • Ensure proper error handling for the field list mapping; consider logging errors or throwing exceptions at appropriate levels.
  • If the form data might change frequently, consider memoizing the derived state to improve performance.
  • Use more descriptive variable names and ensure consistent naming conventions within classes.

Expand Down