fix: The default suffix for workflow file upload nodes is set to uppercase DOC and PPT #3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcase DOC and PPT
shaohuzhang1
commented
May 21, 2025
| @@ -141,7 +141,7 @@ | |||
| <p class="line-height-22 mt-4"> | |||
| {{ $t('common.fileUpload.other') }} | |||
| <el-text class="color-secondary" | |||
| >{{ | |||
| >{{ | |||
| $t( | |||
| 'views.applicationWorkflow.nodes.baseNode.FileUploadSetting.fileUploadType.otherText' | |||
| ) | |||
There was a problem hiding this comment.
There seem to be two instances where there is an extra > character after $t() calls:
<el-text class="color-secondary">{{Ensure that these should instead be:
<el-text class="color-secondary">{{ --}}Additionally, it's a good practice to use single quotes around template literals to avoid syntax errors, especially when mixing inline and multi-line templates. Here’s how you can fix them:
Before:
'{{ $t('someKey', 'arg1 arg2') }}'After replacing double/single quotes for consistency:
"$t('someKey', 'arg1 args2')"Or using single quotes if prefered for clarity within the string itself:
'$t(\'someKey\', \'arg1 args2\')'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: The default suffix for workflow file upload nodes is set to uppercase DOC and PPT