Skip to content

perf: Refine the Model Manager code #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

perf: Refine the Model Manager code #3098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions apps/common/util/rsa_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,12 @@ def generate():
def get_key_pair():
rsa_value = rsa_cache.get(cache_key)
if rsa_value is None:
lock.acquire()
rsa_value = rsa_cache.get(cache_key)
if rsa_value is not None:
return rsa_value
try:
with lock:
rsa_value = rsa_cache.get(cache_key)
if rsa_value is not None:
return rsa_value
rsa_value = get_key_pair_by_sql()
rsa_cache.set(cache_key, rsa_value)
finally:
lock.release()
return rsa_value


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no error in this code, but there is an inefficiency in obtaining keys. If a key pair already exists in the cache, it does not need to fetch one from the database each time because rsa_cache.set(cache_key, rsa_value) will always overwrite the existing value in the cache even if the key pair hasn't changed.

To optimize this function, you can modify it so that only calls to get_key_pair_by_sql() actually fetch data from the database:

def generate():
    def get_key_pair():
        rsa_value = rsa_cache.get(cache_key)
        if rsa_value is None:
            with lock:
                rsa_value = rsa_cache.get(cache_key)
                if rsa_value is not None:
                    return rsa_value
                # Fetch keys from database only if they're missing.
                rsa_value = get_key_pair_by_sql() if not has_new_keys else None
                if rsa_value is not None:
                    rsa_cache.set(cache_key, rsa_value)
                    has_new_keys = True  # Reset flag after adding new values.
        return rsa_value

    has_new_keys = False
    generate()

If we know in advance when a full update is likely (for instance, during system startup), has_new_keys could be set once at the start of application initialization phase instead of checking every access to generate. This avoids unnecessary queries while still providing quick response on demand unless a full refresh might be needed sooner due to some event.

Expand Down