Skip to content

feat: add pool options recycle #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

feat: add pool options recycle #3080

merged 1 commit into from
May 13, 2025

Conversation

shaohuzhang1
Copy link
Contributor

feat: add pool options recycle

Copy link

f2c-ci-robot bot commented May 13, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -114,7 +114,8 @@ def get_db_setting(self) -> dict:
"ENGINE": self.get('DB_ENGINE'),
"POOL_OPTIONS": {
"POOL_SIZE": 20,
"MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW'))
"MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW')),
'RECYCLE': 30 * 60
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be functioning correctly without apparent issues. However, it can be optimized slightly:

@@ -114,7 +114,8 @@ def get_db_setting(self) -> dict:
             "ENGINE": self.get('DB_ENGINE'),
             "POOL_OPTIONS": {
                 "POOL_SIZE": 20,
-                "MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW'))
+                "MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW')) if self.get('DB_MAX_OVERFLOW') else None,
+                'RECYCLE': 30 * 60
             }
         }

Optimizations Made:

  1. Default Value Handling: Added a check using an if statement to set the MAX_OVERFLOW value to None if it is not found in the configuration, preventing unnecessary conversion attempts (int(None)).

This change ensures that any missing or empty DB_MAX_OVERFLOW configuration values will gracefully handle this scenario without raising exceptions when converting them to integers.

@shaohuzhang1 shaohuzhang1 merged commit ccf43bb into main May 13, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@feat_add_recycle branch May 13, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant