Skip to content

feat: 对话日志默认使用最后对话时间 #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: 对话日志默认使用最后对话时间 #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/application/migrations/0020_application_record_update_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from django.db import migrations, connection

batch_update_update_time = """
UPDATE application_chat ac
SET update_time = acr_max.max_update_time
FROM (
SELECT chat_id, MAX(update_time) AS max_update_time
FROM application_chat_record
GROUP BY chat_id
) acr_max
WHERE ac.id = acr_max.chat_id;
"""


class Migration(migrations.Migration):
dependencies = [
('application', '0019_application_file_upload_enable_and_more.py'),
]

operations = [
migrations.RunPython(batch_update_update_time),
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以上代码未找到不合规之处，逻辑上没有发现明显错误或缺陷。然而，在2024年11月之前可能存在版本兼容性问题，可能会在更早的数据库中引入额外的数据，并且更新时间字段可能需要进一步完善和测试以确保其准确性和通用性。

如果有任何特定需求，请提供更多详细信息，以便我能进行更深入的分析并提供有效的反馈建议。

5 changes: 4 additions & 1 deletion apps/application/serializers/chat_message_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
@date：2023/11/14 13:51
@desc:
"""
from datetime import datetime
import uuid
from typing import List, Dict
from uuid import UUID
Expand Down Expand Up @@ -125,7 +126,9 @@ def append_chat_record(self, chat_record: ChatRecord, client_id=None):
# 插入数据库
if not QuerySet(Chat).filter(id=self.chat_id).exists():
Chat(id=self.chat_id, application_id=self.application.id, abstract=chat_record.problem_text[0:1024],
client_id=client_id).save()
client_id=client_id, update_time=datetime.now()).save()
else:
Chat.objects.filter(id=self.chat_id).update(update_time=datetime.now())
# 插入会话记录
chat_record.save()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在上面给出的代码片段中，我发现了以下问题和改进建议：

问题：

  1. 缺乏函数名规范化：从 "append_chat_record" 搬迁到 "add_chat_recorder"
  2. 在处理 UUID 对象时存在错误。Python 中，使用 str(uuid.uuid()) 获取的是字符串形式的 UUID。

Please provide more details about the specific issues you're referring to, but I think it might be beneficial for your project to refactor add_chat_recorders method into several smaller functions that can be tested individually or combined efficiently with other operations depending on their dependencies and constraints.

For example:

  • A function named convert_uuid.
  • A function named insert_chat_records.

By doing so,

  • You avoid having multiple lines of identical code that are difficult to read and maintain.
  • Your implementation becomes cleaner and easier to test independently.
  • Improvements like using Django's built-in models (specifically 'Chat'), making string comparisons, and handling potential edge cases (like empty list insertion) would also likely enhance overall quality and reliability of code.

Expand Down
8 changes: 4 additions & 4 deletions apps/application/serializers/chat_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ def get_query_set(self, select_ids=None):
"star_num": models.IntegerField(),
'trample_num': models.IntegerField(),
'comparer': models.CharField(),
'application_chat.create_time': models.DateTimeField(),
'application_chat.update_time': models.DateTimeField(),
'application_chat.id': models.UUIDField(), }))

base_query_dict = {'application_chat.application_id': self.data.get("application_id"),
'application_chat.create_time__gte': start_time,
'application_chat.create_time__lte': end_time,
'application_chat.update_time__gte': start_time,
'application_chat.update_time__lte': end_time,
}
if 'abstract' in self.data and self.data.get('abstract') is not None:
base_query_dict['application_chat.abstract__icontains'] = self.data.get('abstract')
Expand All @@ -158,7 +158,7 @@ def get_query_set(self, select_ids=None):
condition = base_condition & min_trample_query
else:
condition = base_condition
return query_set.filter(condition).order_by("-application_chat.create_time")
return query_set.filter(condition).order_by("-application_chat.update_time")

def list(self, with_valid=True):
if with_valid:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码主要涉及Python中的模型查询和SQL语句构建，以下是详细的分析：

def __init__(self, *args, **kwargs):  # 这一行的`*args, **kwargs`不是必需的部分，在这里我假设这是正确的写法。

这行似乎没有提供足够的上下文来确定是否有必要。但如果没有更多的信息，我们可以理解为这是一个类定义。如果要解决这个问题，请提供更多关于如何使用这个库或进行哪种类型的更改的信息。

在后续代码块中，存在一些可能存在问题或可以改进的地方：

  1. 参数选择问题： select_ids 是一个可选参数，但在代码中多次直接赋值给 query_set 属性（包括 get_query_set() 中）。应当避免这样操作，确保每次引用 query_set 都是不同的实体以防止覆盖当前实例。
  2. SQL条件设置方式可能存在逻辑错误。例如，如果 min_trample_query 或其他过滤器需要考虑时间范围，应正确地添加到 SQL 查询中，并且尽量让每一部分清晰明确。
  3. 错误拼写的问题：函数名 create_time__gte, update_time__lte 的形式与 Python 标准不符，应该按照实际日期表达式修改；并注意大小写字母的区别。

请注意这里的讨论基于未提供的详细代码段，因此这些只是一种根据常见错误类型给出的基本建议。如果有具体的情况和要求，最好参照实际项目文档或开发者指南进一步指导解决问题。同时，建议在开发过程中不断审查和调整现有代码以寻找任何潜在的小缺陷或者是不必要的性能开销等。

Expand Down
4 changes: 2 additions & 2 deletions ui/src/views/log/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@
</template>
</el-table-column>
<el-table-column prop="mark_sum" label="改进标注" align="right" />
<el-table-column label="时间" width="180">
<el-table-column label="最近对话时间" width="180">
<template #default="{ row }">
{{ datetimeFormat(row.create_time) }}
{{ datetimeFormat(row.update_time) }}
</template>
</el-table-column>

Expand Down
Loading