fix: 修复日志导出格式不正确的缺陷 #1593
fix: 修复日志导出格式不正确的缺陷 #1593
Conversation
--bug=1048673 --user=王孝刚 【应用】导出对话日志是xls格式，excel 打开提示文件格式不对 https://www.tapd.cn/57709429/s/1608292
| param, | ||
| data, | ||
| loading | ||
| ) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
这个函数exportChatLog没有明显的缺陷，但是它有一些不明确或可能需要改进的地方。
- 在参数中使用引号会导致一些浏览器和库出现兼容性问题。
- 函数名拼写错误，应该从'excel'改成'xls'
- 参数
data,loading未定义
我为您推荐一个修改后的版本：
const exportChatLog = async ({ application_id }, {
param,
data,
loading
}) => {
await exportExcel({
fileName: `${prefix}/${application_id}/chat/export.xlsx`
})
return {
success: true,
};
};这样可以避免字符串拼写错误，并将数据传递给exportExcelPost方法。
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: 修复日志导出格式不正确的缺陷 --bug=1048673 --user=王孝刚 【应用】导出对话日志是xls格式，excel 打开提示文件格式不对 https://www.tapd.cn/57709429/s/1608292