feat: 去除工作流直接返回内容的标题数据 #1575
feat: 去除工作流直接返回内容的标题数据 #1575
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -73,7 +73,7 @@ def execute(self, dataset_id_list, dataset_setting, question, | |||
| [f"{reset_title(paragraph.get('title', ''))}{paragraph.get('content')}" for paragraph in | |||
| paragraph_list])[0:dataset_setting.get('max_paragraph_char_number', 5000)], | |||
| 'directly_return': '\n'.join( | |||
| [f"{reset_title(paragraph.get('title', ''))}{paragraph.get('content')}" for paragraph in | |||
| [paragraph.get('content') for paragraph in | |||
| result if | |||
| paragraph.get('is_hit_handling_method')]), | |||
| 'question': question}, | |||
There was a problem hiding this comment.
没有发现明显的问题或异常，在现有的情况下是正确的。如果您有任何其他特殊要求或特定问题，请告诉我，以便我为您提供更详细和针对性的反馈。
| finally: | ||
| self.work_flow_post_handler.handler(self.params['chat_id'], self.params['chat_record_id'], | ||
| self.answer, | ||
| self) | ||
| yield self.get_chunk_content('', True) | ||
|
|
||
| def run_chain_async(self, current_node): | ||
| future = executor.submit(self.run_chain, current_node) |
There was a problem hiding this comment.
该段代码看起来是用于处理与对话相关的任务的，但它包含了一些不太一致的地方。以下是针对这些地方提出的一些建议：
-
定义
run_chain函数时，可以提供一个参数params而不是self. -
在调用
get_chunk_content之前使用`yield self```来确保返回的数据被适当地关闭。 -
调用其他链的运行时，直接传递链的当前节点作为第一个参数，并在执行完后将结果作为一个future提交给异步线程池中的
submit方法即可。
通过实施上述修改，代码的质量会更高，更符合编程规范和最佳实践的要求。请根据最新的编程标准更新这段代码，以使其更加现代和健壮。
fix: 添加对话stream流式结束标记
feat: 去除工作流直接返回内容的标题数据