-
Notifications
You must be signed in to change notification settings - Fork 2.1k
refactor: 优化文案 #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 优化文案 #1571
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
const fieldNames: { [key: string]: string } = { | ||
corp_id: 'Corp ID', | ||
app_key: 'APP Key', | ||
app_key: item?.key != 'lark' ? 'APP Key' : 'App ID', | ||
app_secret: 'APP Secret', | ||
agent_id: 'Agent ID', | ||
callback_url: '回调地址' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该段代码中的问题在于使用了旧版的变量名和格式化字符串,应改写为更现代的方式来处理这些信息。
以下是建议的更改:
const fieldNames = {
corp_id: ' Corp Name ',
// ... 其余键值对修改...
};
这样可以避免不必要的混淆,并使代码更加模块化和可维护。
@@ -80,7 +80,7 @@ const currentPlatform = reactive<Platform>({ | |||
const formatFieldName = (key?: any): string => { | |||
const fieldNames: { [key: string]: string } = { | |||
corp_id: 'Corp ID', | |||
app_key: 'APP Key', | |||
app_key: currentPlatform?.key != 'lark' ? 'APP Key' : 'App ID', | |||
app_secret: 'APP Secret', | |||
agent_id: 'Agent ID', | |||
callback_url: '回调地址' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有发现任何特定的文本错误或问题。代码看起来是正确的并且符合当前的编程标准。
refactor: 优化文案