Skip to content

Commit 7a861ab

Browse files
committed
fix(components): 🐛 the ref method of the vc-zoom-control component exposed errors
1 parent 1d7137d commit 7a861ab

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

packages/components/controls/zoom-control/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,9 @@ export default defineComponent({
240240
}
241241

242242
Object.assign(instance.proxy, {
243-
zoomIn: () => zoomControlState.zoomIn,
244-
zoomOut: () => zoomControlState.zoomOut,
245-
zoomReset: () => zoomControlState.zoomReset
243+
zoomIn: (e?: MouseEvent) => zoomControlState.zoomIn(e),
244+
zoomOut: (e?: MouseEvent) => zoomControlState.zoomOut(e),
245+
zoomReset: (e?: MouseEvent) => zoomControlState.zoomReset(e)
246246
})
247247

248248
return () => {

packages/components/controls/zoom-control/use-zoom-control.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
1010
const zoomOutTooltipRef = ref<VcTooltipRef>(null)
1111
const resetTooltipRef = ref<VcTooltipRef>(null)
1212

13-
const zoomIn = e => {
13+
const zoomIn = (e?: MouseEvent) => {
1414
zoom(1 / props.zoomAmount, e)
1515
}
1616

17-
const zoomOut = e => {
17+
const zoomOut = (e?: MouseEvent) => {
1818
zoom(props.zoomAmount, e)
1919
}
2020

21-
const zoom = (relativeAmount, e) => {
21+
const zoom = (relativeAmount, e?: MouseEvent) => {
2222
$(zoomInTooltipRef)?.hide()
2323
$(zoomOutTooltipRef)?.hide()
2424

@@ -129,7 +129,7 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
129129
}
130130
}
131131

132-
const zoomReset = e => {
132+
const zoomReset = (e?: MouseEvent) => {
133133
$(resetTooltipRef)?.hide()
134134
const { viewer } = $services
135135
const scene = viewer.scene
@@ -145,7 +145,7 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
145145
viewer.trackedEntity = trackedEntity
146146
} else {
147147
const listener = getInstanceListener(vcInstance, 'zoomEvt')
148-
const target = e.currentTarget
148+
const target = e?.currentTarget
149149
const level = heightToLevel(viewer.camera.positionCartographic.height).toFixed(0)
150150
// reset to a default position or view defined in the options
151151
listener &&

0 commit comments

Comments
 (0)