[Dev Tools] forge test --zk-sync fails on vm.revert()

[0xBeans]

Team or Project

Abstract

ZK chain

Abstract

Environment

Mainnet

Select the Dev Tool you are using

Foundry

Provide the version of the tool (if applicable)

1.0.0-foundry-zksync-v0.0.11

Provide a brief description of the functionality you're trying to implement and the issue you are running into.

In my test file, I have:

vm.expertRevert()
contract.call()

When I run forge test it passes, but when I run forge test --zk-sync I get this error:

[FAIL: call didn't revert at a lower depth than cheatcode call depth]

Does ZK Foundry treat reverts inside deep call stacks differently?

Repo Link (Optional)

No response

Additional Details

No response

[ly0va]

Hi @0xBeans, can you please provide the whole test source so that we can reproduce it?

[0xBeans]

It's from a team that wants to keep their repo private but the structure is as follows:

LibErrors.sol:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

library Errors {
    error IncorrectValue();
}

Main.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

import {Errors} from 'LibErrors.sol';

contract Main {
    function purchase() external payable {
        if (msg.value != price) {
            revert Errors.IncorrectValue();
        }
    }
}

Test File:

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.19;

import {Test, console} from "forge-std/Test.sol";
import {Main} from "../src/Main.sol";
import {Errors} from "../src/LibErrors.sol";

contract CounterTest is Test {
    Main public main;

    address admin = address(0x11);
    address user1 = address(0xaa);
    address user2 = address(0xbb);

    function setUp() public {
        main = new Main();
    }

    function testPurchase() public {
        vm.startPrank(user1);
        vm.deal(user1, 1 ether);

        vm.expectRevert();
        main.purchaseInitialFacility{value: 0.1 ether}();
    }
}

[0xBeans]

[0xBeans]

[ly0va]

Setting allow_internal_expect_revert = true in foundry.toml should resolve the issue.

Feel free to unmark this as answered if it doesn't.

[0xBeans]

Can you clarify why this solves the issue?

[dutterbutter]

Related issue with more context: matter-labs/foundry-zksync#950

@0xBeans we will be prioritizing the investigation of this issue further but please see the above for more information, specifically: https://book.getfoundry.sh/guides/v1.0-migration#expect-revert-cheatcode-disabled-on-internal-calls-by-default

[0xBeans]

amazing thank you, ill mark this is resolved for now.