[Deployment] Wrong address derivation

[xrave110]

Team or Project

No response

ZK chain

Local anvil-zksync, Era

Environment

Mainnet

L2 block number

No response

zkSolc Version

1.3.22

zksync-ethers Version

Minimal Reproducible Code or Repo Link

FOUNDRY .toml:

[profile.default]
zksolc_version = "1.3.22"
is_system = true
src = 'src'
out = 'out'
libs = ['lib']

contract MakeERC20 is ERC20, Initializable {
    string internal tokenName;
    string internal tokenSymbol;

    /**
     * @dev Constructor that disables initializers for this contract.
     */
    constructor() {
        _disableInitializers();
    }

    function initialize(string memory _name, string memory _symbol, uint256 _totalSupply) external initializer {
        tokenName = _name;
        tokenSymbol = _symbol;
        _mint(msg.sender, _totalSupply);
    }

    function name() public view override returns (string memory) {
        return tokenName;
    }

    function symbol() public view override returns (string memory) {
        return tokenSymbol;
    }
}

contract SimpleStorageZkSync {
    address[] public listOfTokens;

    function makeDeterministicToken(bytes32 _salt) public {
        address token_ = address(new MakeERC20{salt: _salt}());

        listOfTokens.push(token_);
    }

    function predictAddress(bytes32 salt) public view returns (address) {
        bytes memory creationCode = type(MakeERC20).creationCode;
        bytes32 bytecodeHash = keccak256(creationCode);
        bytes32 senderBytes = bytes32(uint256(uint160(address(this))));

        // Use zkSync's precomputed CREATE2_PREFIX
        bytes32 ZKSYNC_CREATE2_PREFIX = 0x2020dba91b30cc0006188af794c2fb30dd8520db7e2c088b7fc7c103c00ca494; // or keccak256("zksyncCreate2")

        bytes32 data = keccak256(
            bytes.concat(
                ZKSYNC_CREATE2_PREFIX, // Correct prefix
                senderBytes,
                salt,
                bytecodeHash,
                keccak256(abi.encode()) // Constructor args hash
            )
        );

        return address(uint160(uint256(data)));
    }
}

TEST:

    SimpleStorageZkSync public simpleStorageZkSync;

    function setUp() external {
        vm.createSelectFork("https://mainnet.era.zksync.io", 57404928);
        simpleStorageZkSync = new SimpleStorageZkSync();
    }

    function testMakeDeterministicTokenZkSync(uint256 salty) public {
        bytes32 salt = bytes32(abi.encode(2));

        address predictedToken1 = simpleStorageZkSync.predictAddress(salt);
        console2.log("1.predictedToken1", predictedToken1);

        simpleStorageZkSync.makeDeterministicToken(salt);
        console2.log(simpleStorageZkSync.listOfTokens(0));

        assertEq(predictedToken1, simpleStorageZkSync.listOfTokens(0), "Wrong token address ");
    }

Does this work on other EVMs? (If yes, please list at least 1 of them)

No

Description of What Your Contract Does

Hello,
I am trying to predict address of token creation (create2) according to this doc:
https://docs.zksync.io/zksync-era/tooling/foundry/migration-guide/deployment
But the predicted address is different than created via address(new MakeERC20{salt: _salt}()); in makeDeterministicToken function.
To run test I tried multiple variations but nothing worked:
forge test --match-test testMakeDeterministicTokenZkSync --zksync --system-mode=true -vvvv
forge test --match-test testMakeDeterministicTokenZkSync --zksync -vvvv
The same when it comes to .toml file.

Additional Details

Used foundryup-zksync
forge --version returns 0.0.10-dev

[ly0va]

Hi @xrave110!

Please note that bytecode hashes in ZKsync are calculated not the same way as in EVM. Here are reference implementations of hashBytecode from zksync-ethers SDK or ZKsync system contracts.

Also, type(Contract).creationCode does not return the contract bytecode, but only a header passed to the ContractDeployer contract, as per this doc.

Hence, to get the actual bytecodeHash, it might make more sense to compute it offchain using a script and place it in your contract as a constant.

To get the create2 derived address, you may also use ContractDeployer.getNewAddressCreate2 instead of computing it by hand.

Please feel free to unmark this discussion as answered if this does not resolve your issue.