[General] Bridging ERC20 tokens doesn't work

[jarrodwatts]

Team or Project

Abstract

Environment

Testnet

L2 block number

No response

Provide a brief description of the functionality you're trying to implement and the issue you are running into.

https://portal.testnet.abs.xyz/bridge

Repo Link (Optional)

No response

Additional Details

No response

[sarahschwartz]

Hi @jarrodwatts sorry I don't have much context here. Can you share the repo you are using for this site?

[cytadela8]

Hi @jarrodwatts, I'm not sure if I reproduced the same error, but I was able to find something.

Looking at the console, it seems to me that bridging is performed without requesting approval first. This seems to match with approval normally being performed on the previous screen. Debugging this further would require looking at the source code of the app. Please share the code preferably in the form of a git repository so we can see where did you diverge from our repo.

[sarahschwartz]

@jarrodwatts I've confirmed that this is the issue. I'm not sure where the difference is code is coming from exactly, but there is no request for approval during the flow. It seems like the issue is related to the logic for the checking for if an allowance is needed for the selected token.

[bxpana]

@jarrodwatts the issue was resolved and fixed in this PR. Already touched base with your team for fixing on the Abstract Portals.