zkvm-solc 0.5.16-1.0.1

[Fataydo]

Team or Project

No response

Which compiler are you using?

• zksolc
• zkvyper

Which version of Solidity or Vyper?

0.8.0, 0.5.16, 0.5.0

zksolc/zkvyper version?

1.5.7

Explain the issue

The zksolc compiler version in your Hardhat config file (1.5.7) is not the latest. We recommend using the latest version 1.5.9.
Compiling contracts for ZKsync Era with zksolc v1.5.7 and zkvm-solc v0.8.0-1.0.1
Compiling 22 Solidity files
Downloading zkvm-solc 0.5.16-1.0.1
UnimplementedFeatureError: Modifiers not implemented yet.

Error in plugin @matterlabs/hardhat-zksync-solc: Failed to download https://github.com/matter-labs/era-solidity/raw/main/windows-amd64/solc-windows-amd64-0.5.16-1.0.1.exe - 404 received.

I am trying to compile uniswapv2 contracts and get this error. Idk how to fix it.

UniswapV2ERC20.sol
UniswapV2Factory.sol
UniswapV2Pair.sol

Link to your repo?

No response

[popzxc]

Hello! A few things here:

1. Compiling Uniswap V2 contracts for ZKsync requires modification and will not work out of the box.
2. Uniswap V3 is deployed on ZKsync using modified contracts that you can find here: https://github.com/uniswap-zksync
3. Even for V3, deployment of Uniswap contracts is highly non-trivial, so I would recommend starting from simpler contracts until you feel comfortable with ZKsync specifics.
4. Windows support for ZKsync is incomplete, and in this case the required compiler part is not provided for Windows. If you're using Windows, it's highly recommended to use WSL