temp

Author: zk-steve

README.md

@@ -102,16 +102,17 @@ Hierarchical child config via env, separated by using `__`. Specify list values
 | SERVER\_\_PORT                                                           |               |           |
 | SERVICE_NAME                                                             |               |           |
 | EXPORTER_ENDPOINT                                                        |               |           |
-| DB\_\_PG\_\_URL                                                          |               |           |
-| DB\_\_PG\_\_MAX_SIZE                                                     |               |           |
-| REDIS\_\_HOST                                                            |               |           |
-| REDIS\_\_PORT                                                            |               |           |
+| DB\_\_PG\_\_URL                                                          | "LOCALHOST"   |           |
+| DB\_\_PG\_\_MAX_SIZE                                                     | "5432"        |           |
+| REDIS\_\_HOST                                                            | "LOCALHOST"   |           |
+| REDIS\_\_PORT                                                            | "6379"        |           |
 
 Make sure to set these environment variables according to your needs before running the server.
 
 ## GitHub Flow CI Configuration
 
 1. **Set Docker Hub Secrets:**
+
    - Go to repository Settings > Secrets.
    - Add `DOCKER_USERNAME` and `DOCKERHUB_TOKEN`.
 

src/adapter/src/repositories/in_memory/cache.rs

@@ -15,6 +15,15 @@ pub struct InMemoryCache {
     cache: Arc<RwLock<HashMap<String, (String, Option<SystemTime>)>>>,
 }
 
+impl Default for InMemoryCache {
+    /// Creates a new default instance of in-memory cache.
+    fn default() -> Self {
+        Self {
+            cache: Arc::new(RwLock::default()),
+        }
+    }
+}
+
 impl InMemoryCache {
     /// Removes expired entries from the cache asynchronously.
     ///
@@ -34,15 +43,6 @@ impl InMemoryCache {
     }
 }
 
-impl Default for InMemoryCache {
-    /// Creates a new default instance of in-memory cache.
-    fn default() -> Self {
-        Self {
-            cache: Arc::new(RwLock::new(HashMap::new())),
-        }
-    }
-}
-
 #[async_trait]
 impl CachePort for InMemoryCache {
     /// Retrieves a value from the cache based on the provided key.
@@ -89,8 +89,10 @@ impl CachePort for InMemoryCache {
         // Calculate expiry_time based on expiration duration
         let expiry_time = expiration.map(|exp| SystemTime::now() + exp);
 
-        let mut cache = self.cache.write().await;
-        cache.insert(key.to_string(), (value.to_string(), expiry_time));
+        self.cache
+            .write()
+            .await
+            .insert(key.to_string(), (value.to_string(), expiry_time));
         Ok(())
     }
 
@@ -104,11 +106,11 @@ impl CachePort for InMemoryCache {
     ///
     /// Returns `Ok(())` if the key is found and removed, otherwise returns a `CoreError`.
     async fn del(&mut self, key: &str) -> Result<(), CoreError> {
-        let mut cache = self.cache.write().await;
-        if cache.remove(key).is_some() {
-            Ok(())
-        } else {
-            Err(CoreError::NotFound)
-        }
+        self.cache
+            .write()
+            .await
+            .remove(key)
+            .map(|_| ())
+            .ok_or(CoreError::NotFound)
     }
 }

src/adapter/src/repositories/redis/cache.rs

@@ -61,7 +61,7 @@ impl CachePort for RedisCache {
     ///
     /// # Returns
     ///
-    /// Returns a `Result` indicating success (`true`) or failure (`false`).
+    /// Returns a `Result` where `Ok(())` indicates success (key was set) and `Err(CoreError)` indicates failure.
     async fn set(
         &mut self,
         key: &str,

src/core/src/ports/cache.rs

@@ -28,7 +28,7 @@ pub trait CachePort {
     ///
     /// # Returns
     ///
-    /// Returns `true` if the key-value pair is successfully set in the cache, `false` otherwise.
+    /// Returns `Result(())` if the key-value pair is successfully set in the cache, `false` otherwise.
     async fn set(
         &mut self,
         key: &str,
@@ -44,6 +44,6 @@ pub trait CachePort {
     ///
     /// # Returns
     ///
-    /// Returns `true` if the key-value pair is successfully removed from the cache, `false` otherwise.
+    /// Returns `Result(())` if the key-value pair is successfully removed from the cache, `false` otherwise.
     async fn del(&mut self, key: &str) -> Result<(), CoreError>;
 }