Fix deprecated functions (#329)

Fixup a couple more function deprecations.
* Add a test for rest client package.

Signed-off-by: SuperQ <superq@gmail.com>

Author: SuperQ

pkg/external/iam/aliyun.go

@@ -74,12 +74,12 @@ func (c *CredentialProvider) Retrieve() (minioCred.Value, error) {
 // according to the caller minioCred.Credentials.IsExpired(),
 // it already has a lock, so we don't need to worry about concurrency
 func (c CredentialProvider) IsExpired() bool {
-	ak, err := c.aliyunCreds.GetAccessKeyId()
+	cred, err := c.aliyunCreds.GetCredential()
 	if err != nil {
 		log.Println("failed to get access key id from aliyun credential, assume it's expired")
 		return true
 	}
-	return *ak != c.akCache
+	return *cred.AccessKeyId != c.akCache
 }
 
 // RetrieveWithCredContext implements "github.com/minio/minio-go/v7/pkg/credentials".Provider.RetrieveWithCredContext()

pkg/util/rest/rest_client.go

@@ -86,7 +86,7 @@ func (clis RestClientImpl) Exec(ctx context.Context, namespace, pod, container s
 	}
 
 	var stdoutBuf, stderrBuf bytes.Buffer
-	err = exec.Stream(remotecommand.StreamOptions{
+	err = exec.StreamWithContext(ctx, remotecommand.StreamOptions{
 		Stdout: &stdoutBuf,
 		Stderr: &stderrBuf,
 	})

pkg/util/rest/rest_client_test.go

@@ -0,0 +1,20 @@
+package rest
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	ctrl "sigs.k8s.io/controller-runtime"
+)
+
+func TestNewRestClientImpl(t *testing.T) {
+	config := ctrl.GetConfigOrDie()
+	restClient, err := newRestClientImpl(config)
+	assert.NoError(t, err)
+	assert.NotNil(t, restClient)
+
+	_, _, err = restClient.Exec(context.TODO(), "test", "test", "test", []string{"/bin/true"})
+	// We don't expect this to work in tests.
+	assert.Error(t, err)
+}