Skip to content

Commit 6354851

Browse files
author
r00ster91
committed
fix: "dialog" -> "modal"
"Dialog" is the incorrect term here because a dialog is a separate window that still lets you use the app but a modal is a window where you can't continue using the app until you close it.
1 parent 4ef567b commit 6354851

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

lib/docs/index.html

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@
294294
padding: 1px 1em;
295295
}
296296

297-
/* help dialog */
298297
.help-modal {
299298
display: flex;
300299
width: 100%;
@@ -308,7 +307,7 @@
308307
backdrop-filter: blur(0.3em);
309308
}
310309

311-
.help-modal > .dialog {
310+
.help-modal > .modal {
312311
max-width: 97vw;
313312
max-height: 97vh;
314313
overflow: auto;
@@ -707,12 +706,12 @@ <h2>Tests</h2>
707706
<div class="flex-filler"></div>
708707
</div>
709708
</div>
710-
<div id="helpDialog" class="hidden">
709+
<div id="helpModal" class="hidden">
711710
<div class="help-modal">
712-
<div class="dialog">
711+
<div class="modal">
713712
<h1>Keyboard Shortcuts</h1>
714-
<dl><dt><kbd>?</kbd></dt><dd>Show this help dialog</dd></dl>
715-
<dl><dt><kbd>Esc</kbd></dt><dd>Clear focus; close this dialog</dd></dl>
713+
<dl><dt><kbd>?</kbd></dt><dd>Show this help modal</dd></dl>
714+
<dl><dt><kbd>Esc</kbd></dt><dd>Clear focus; close this modal</dd></dl>
716715
<dl><dt><kbd>s</kbd></dt><dd>Focus the search field</dd></dl>
717716
<dl><dt><kbd></kbd></dt><dd>Move up in search results</dd></dl>
718717
<dl><dt><kbd></kbd></dt><dd>Move down in search results</dd></dl>

lib/docs/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var zigAnalysis;
4848
let domPrivDeclsBox = document.getElementById("privDeclsBox");
4949
let domTdZigVer = document.getElementById("tdZigVer");
5050
let domHdrName = document.getElementById("hdrName");
51-
let domHelpModal = document.getElementById("helpDialog");
51+
let domHelpModal = document.getElementById("helpModal");
5252

5353
let searchTimer = null;
5454

0 commit comments

Comments
 (0)