Add OnHierarchyChangeListener to accessibilityOrder parent to track changes in hierarchy (facebook#50261)

Summary:
Pull Request resolved: facebook#50261

Since now we have the optimization of only running the custom accessibility order when we define the tree as dirty we need to add a hierarchy change listener on all ViewGroups within the parent to notify accessibility services of potential changes in hierarchy and so mark the subtree as dirty.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D71821636

fbshipit-source-id: 25649efa1679024a205e94c340511dc58783d575

Author: jorge-cab

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@@ -307,6 +307,31 @@ public void setAccessibilityOrder(@NonNull T view, @Nullable ReadableArray nativ
     view.setTag(R.id.accessibility_order, nativeIds);
     view.setTag(R.id.accessibility_order_dirty, true);
 
+    if (view instanceof ViewGroup) {
+      ((ViewGroup) view)
+          .setOnHierarchyChangeListener(
+              new ViewGroup.OnHierarchyChangeListener() {
+                @Override
+                public void onChildViewAdded(View parent, View child) {
+                  view.setTag(R.id.accessibility_order_dirty, true);
+
+                  // We also want to listen to changes on the hierarchy of nested ViewGroups
+                  if (child instanceof ViewGroup) {
+                    ViewGroup childGroup = (ViewGroup) child;
+                    childGroup.setOnHierarchyChangeListener(this);
+                    for (int i = 0; i < childGroup.getChildCount(); i++) {
+                      onChildViewAdded(childGroup, childGroup.getChildAt(i));
+                    }
+                  }
+                }
+
+                @Override
+                public void onChildViewRemoved(View parent, View child) {
+                  view.setTag(R.id.accessibility_order_dirty, true);
+                }
+              });
+    }
+
     ReactAxOrderHelper.unsetAccessibilityOrder(view);
     ((ViewGroup) view)
         .notifySubtreeAccessibilityStateChanged(

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java

@@ -142,7 +142,7 @@ public void onInitializeAccessibilityNodeInfo(View host, AccessibilityNodeInfoCo
       boolean isAxOrderDirty = (boolean) host.getTag(R.id.accessibility_order_dirty);
       if (isAxOrderDirty) {
         ReactAxOrderHelper.setCustomAccessibilityFocusOrder(host);
-        host.setTag(R.id.accessibility_order_dirty);
+        host.setTag(R.id.accessibility_order_dirty, false);
       }
     }
 

packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/ids.xml

@@ -9,7 +9,7 @@
   <!-- tag is used to store the accessibleElements tag -->
   <item type="id" name="accessibility_order"/>
 
-  <!-- tag is used to store the accessibleElements tag -->
+  <!-- tag is used to store the current state of the accessibility order tree-->
   <item type="id" name="accessibility_order_dirty"/>
 
   <!-- tag is used to store the accessibleElements parent View tag -->