Deprecate *EventData types in favour of *Event (facebook#50215)

Summary:
Pull Request resolved: facebook#50215

Backwards compatible updates to `CoreEventTypes`, `Image`, `Switch`, `TextInput` to align types and reduce root exports.

The effects of this change can be seen in `packages/react-native/types/__typetests__/index.tsx` (smoke test file against current manual TypeScript definitions).

Under Flow, exports on each `*EventData` type are directly removed (unreferenced).

Changelog:
[General][Deprecated] - Deprecate `*EventData` types on `Image`, `Switch`, `TextInput` components. These can be substituted for `*Event`, e.g. `NativeSyntheticEvent<ImageLoadEventData>` becomes `ImageLoadEvent`.

Reviewed By: NickGerleman

Differential Revision: D71734361

fbshipit-source-id: 287c775e840319242984d248169c267abf8f032b

Author: huntie

packages/react-native/Libraries/Components/Switch/Switch.d.ts

@@ -38,6 +38,9 @@ export interface SwitchPropsIOS extends ViewProps {
   tintColor?: ColorValue | undefined;
 }
 
+/**
+ * @deprecated Use `SwitchChangeEvent` instead.
+ */
 export interface SwitchChangeEventData extends TargetedEvent {
   value: boolean;
 }

packages/react-native/Libraries/Components/Switch/Switch.js

@@ -46,7 +46,7 @@ export type SwitchPropsIOS = {
   tintColor?: ?ColorValue,
 };
 
-export type SwitchChangeEventData = $ReadOnly<{
+type SwitchChangeEventData = $ReadOnly<{
   target: number,
   value: boolean,
 }>;

packages/react-native/Libraries/Components/TextInput/TextInput.d.ts

@@ -455,22 +455,33 @@ export interface TextInputAndroidProps {
 }
 
 /**
- * @see TextInputProps.onFocus
+ * @deprecated Use `TextInputFocusEvent` instead
  */
 export interface TextInputFocusEventData extends TargetedEvent {
   text: string;
   eventCount: number;
 }
 
 /**
- * @see TextInputProps.onScroll
+ * @see TextInputProps.onFocus
+ */
+export type TextInputFocusEvent = NativeSyntheticEvent<TextInputFocusEventData>;
+
+/**
+ * @deprecated Use `TextInputScrollEvent` instead
  */
 export interface TextInputScrollEventData {
   contentOffset: {x: number; y: number};
 }
 
 /**
- * @see TextInputProps.onSelectionChange
+ * @see TextInputProps.onScroll
+ */
+export type TextInputScrollEvent =
+  NativeSyntheticEvent<TextInputScrollEventData>;
+
+/**
+ * @deprecated Use `TextInputSelectionChangeEvent` instead
  */
 export interface TextInputSelectionChangeEventData extends TargetedEvent {
   selection: {
@@ -480,41 +491,77 @@ export interface TextInputSelectionChangeEventData extends TargetedEvent {
 }
 
 /**
- * @see TextInputProps.onKeyPress
+ * @see TextInputProps.onSelectionChange
+ */
+export type TextInputSelectionChangeEvent =
+  NativeSyntheticEvent<TextInputSelectionChangeEventData>;
+
+/**
+ * @deprecated Use `TextInputKeyPressEvent` instead
  */
 export interface TextInputKeyPressEventData {
   key: string;
 }
 
 /**
- * @see TextInputProps.onChange
+ * @see TextInputProps.onKeyPress
+ */
+export type TextInputKeyPressEvent =
+  NativeSyntheticEvent<TextInputKeyPressEventData>;
+
+/**
+ * @deprecated Use `TextInputChangeEvent` instead
  */
 export interface TextInputChangeEventData extends TargetedEvent {
   eventCount: number;
   text: string;
 }
 
 /**
- * @see TextInputProps.onContentSizeChange
+ * @see TextInputProps.onChange
+ */
+export type TextInputChangeEvent =
+  NativeSyntheticEvent<TextInputChangeEventData>;
+
+/**
+ * @deprecated Use `TextInputContentSizeChangeEvent` instead
  */
 export interface TextInputContentSizeChangeEventData {
   contentSize: {width: number; height: number};
 }
 
 /**
- * @see TextInputProps.onEndEditing
+ * @see TextInputProps.onContentSizeChange
+ */
+export type TextInputContentSizeChangeEvent =
+  NativeSyntheticEvent<TextInputContentSizeChangeEventData>;
+
+/**
+ * @deprecated Use `TextInputEndEditingEvent` instead
  */
 export interface TextInputEndEditingEventData {
   text: string;
 }
 
 /**
- * @see TextInputProps.onSubmitEditing
+ * @see TextInputProps.onEndEditing
+ */
+export type TextInputEndEditingEvent =
+  NativeSyntheticEvent<TextInputEndEditingEventData>;
+
+/**
+ * @deprecated Use `TextInputSubmitEditingEvent` instead
  */
 export interface TextInputSubmitEditingEventData {
   text: string;
 }
 
+/**
+ * @see TextInputProps.onSubmitEditing
+ */
+export type TextInputSubmitEditingEvent =
+  NativeSyntheticEvent<TextInputSubmitEditingEventData>;
+
 /**
  * @see https://reactnative.dev/docs/textinput#props
  */
@@ -763,16 +810,12 @@ export interface TextInputProps
   /**
    * Callback that is called when the text input is blurred
    */
-  onBlur?:
-    | ((e: NativeSyntheticEvent<TextInputFocusEventData>) => void)
-    | undefined;
+  onBlur?: ((e: TextInputFocusEvent) => void) | undefined;
 
   /**
    * Callback that is called when the text input's text changes.
    */
-  onChange?:
-    | ((e: NativeSyntheticEvent<TextInputChangeEventData>) => void)
-    | undefined;
+  onChange?: ((e: TextInputChangeEvent) => void) | undefined;
 
   /**
    * Callback that is called when the text input's text changes.
@@ -788,15 +831,13 @@ export interface TextInputProps
    * Only called for multiline text inputs.
    */
   onContentSizeChange?:
-    | ((e: NativeSyntheticEvent<TextInputContentSizeChangeEventData>) => void)
+    | ((e: TextInputContentSizeChangeEvent) => void)
     | undefined;
 
   /**
    * Callback that is called when text input ends.
    */
-  onEndEditing?:
-    | ((e: NativeSyntheticEvent<TextInputEndEditingEventData>) => void)
-    | undefined;
+  onEndEditing?: ((e: TextInputEndEditingEvent) => void) | undefined;
 
   /**
    * Called when a single tap gesture is detected.
@@ -818,33 +859,25 @@ export interface TextInputProps
   /**
    * Callback that is called when the text input is focused
    */
-  onFocus?:
-    | ((e: NativeSyntheticEvent<TextInputFocusEventData>) => void)
-    | undefined;
+  onFocus?: ((e: TextInputFocusEvent) => void) | undefined;
 
   /**
    * Callback that is called when the text input selection is changed.
    */
-  onSelectionChange?:
-    | ((e: NativeSyntheticEvent<TextInputSelectionChangeEventData>) => void)
-    | undefined;
+  onSelectionChange?: ((e: TextInputSelectionChangeEvent) => void) | undefined;
 
   /**
    * Callback that is called when the text input's submit button is pressed.
    */
-  onSubmitEditing?:
-    | ((e: NativeSyntheticEvent<TextInputSubmitEditingEventData>) => void)
-    | undefined;
+  onSubmitEditing?: ((e: TextInputSubmitEditingEvent) => void) | undefined;
 
   /**
    * Invoked on content scroll with
    *  `{ nativeEvent: { contentOffset: { x, y } } }`.
    *
    * May also contain other properties from ScrollEvent but on Android contentSize is not provided for performance reasons.
    */
-  onScroll?:
-    | ((e: NativeSyntheticEvent<TextInputScrollEventData>) => void)
-    | undefined;
+  onScroll?: ((e: TextInputScrollEvent) => void) | undefined;
 
   /**
    * Callback that is called when a key is pressed.
@@ -855,9 +888,7 @@ export interface TextInputProps
    * Fires before onChange callbacks.
    * Note: on Android only the inputs from soft keyboard are handled, not the hardware keyboard inputs.
    */
-  onKeyPress?:
-    | ((e: NativeSyntheticEvent<TextInputKeyPressEventData>) => void)
-    | undefined;
+  onKeyPress?: ((e: TextInputKeyPressEvent) => void) | undefined;
 
   /**
    * The string that will be rendered before text input has been entered

packages/react-native/Libraries/Components/TextInput/TextInput.flow.js

@@ -23,14 +23,13 @@ import {
 } from '../../StyleSheet/StyleSheet';
 import * as React from 'react';
 
-export type TextInputChangeEventData = $ReadOnly<{
+type TextInputChangeEventData = $ReadOnly<{
   eventCount: number,
   target: number,
   text: string,
 }>;
 
-export type TextInputChangeEvent =
-  NativeSyntheticEvent<TextInputChangeEventData>;
+type TextInputChangeEvent = NativeSyntheticEvent<TextInputChangeEventData>;
 
 export type TextInputEvent = NativeSyntheticEvent<
   $ReadOnly<{
@@ -45,7 +44,7 @@ export type TextInputEvent = NativeSyntheticEvent<
   }>,
 >;
 
-export type TextInputContentSizeChangeEventData = $ReadOnly<{
+type TextInputContentSizeChangeEventData = $ReadOnly<{
   target: number,
   contentSize: $ReadOnly<{
     width: number,
@@ -56,11 +55,11 @@ export type TextInputContentSizeChangeEventData = $ReadOnly<{
 export type TextInputContentSizeChangeEvent =
   NativeSyntheticEvent<TextInputContentSizeChangeEventData>;
 
-export type TargetEvent = $ReadOnly<{
+type TargetEvent = $ReadOnly<{
   target: number,
 }>;
 
-export type TextInputFocusEventData = TargetEvent;
+type TextInputFocusEventData = TargetEvent;
 
 export type TextInputBlurEvent = NativeSyntheticEvent<TextInputFocusEventData>;
 export type TextInputFocusEvent = NativeSyntheticEvent<TextInputFocusEventData>;
@@ -70,15 +69,15 @@ type Selection = $ReadOnly<{
   end: number,
 }>;
 
-export type TextInputSelectionChangeEventData = $ReadOnly<{
+type TextInputSelectionChangeEventData = $ReadOnly<{
   ...TargetEvent,
   selection: Selection,
 }>;
 
 export type TextInputSelectionChangeEvent =
   NativeSyntheticEvent<TextInputSelectionChangeEventData>;
 
-export type TextInputKeyPressEventData = $ReadOnly<{
+type TextInputKeyPressEventData = $ReadOnly<{
   ...TargetEvent,
   key: string,
   target?: ?number,
@@ -88,27 +87,27 @@ export type TextInputKeyPressEventData = $ReadOnly<{
 export type TextInputKeyPressEvent =
   NativeSyntheticEvent<TextInputKeyPressEventData>;
 
-/**
- * @see TextInputProps.onEndEditing
- */
-export type TextInputEndEditingEventData = $ReadOnly<{
+type TextInputEndEditingEventData = $ReadOnly<{
   ...TargetEvent,
   eventCount: number,
   text: string,
 }>;
 
+/**
+ * @see TextInputProps.onEndEditing
+ */
 export type TextInputEndEditingEvent =
   NativeSyntheticEvent<TextInputEndEditingEventData>;
 
-/**
- * @see TextInputProps.onSubmitEditing
- */
-export type TextInputSubmitEditingEventData = $ReadOnly<{
+type TextInputSubmitEditingEventData = $ReadOnly<{
   ...TargetEvent,
   eventCount: number,
   text: string,
 }>;
 
+/**
+ * @see TextInputProps.onSubmitEditing
+ */
 export type TextInputSubmitEditingEvent =
   NativeSyntheticEvent<TextInputSubmitEditingEventData>;