Minimize operations in RCTInspectorNetworkReporter in prod (facebook#50242)

Summary:
Pull Request resolved: facebook#50242

Similar to D71636694, adds conditional compile to `RCTInspectorNetworkReporter.mm` to minimize code size and operations performed in production builds.

Specifically:

- Expensive copy of `httpBody` is eliminated.
- Other optional fields that are only mapped when CDP support is enabled are also omitted.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D71637716

fbshipit-source-id: 6c7688b1ac82d2b1047b42a812834a7dfb37cd0f

Author: huntie

packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.h

@@ -13,6 +13,8 @@
  * [Experimental] An interface for reporting network events to the modern
  * debugger server and Web Performance APIs.
  *
+ * In a production (non dev or profiling) build, CDP reporting is disabled.
+ *
  * This is a helper class wrapping
  * `facebook::react::jsinspector_modern::NetworkReporter`.
  */

packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.mm

@@ -9,10 +9,11 @@
 
 #import <jsinspector-modern/network/NetworkReporter.h>
 
-namespace {
-
 using namespace facebook::react::jsinspector_modern;
 
+#ifdef REACT_NATIVE_DEBUGGER_ENABLED
+namespace {
+
 Headers convertNSDictionaryToHeaders(const NSDictionary<NSString *, NSString *> *headers)
 {
   Headers responseHeaders;
@@ -23,6 +24,7 @@ Headers convertNSDictionaryToHeaders(const NSDictionary<NSString *, NSString *>
 }
 
 } // namespace
+#endif
 
 @implementation RCTInspectorNetworkReporter {
 }
@@ -34,8 +36,11 @@ + (void)reportRequestStart:(NSNumber *)requestId
   RequestInfo requestInfo;
   requestInfo.url = [request.URL absoluteString].UTF8String;
   requestInfo.httpMethod = [request.HTTPMethod UTF8String];
+#ifdef REACT_NATIVE_DEBUGGER_ENABLED
+  // Debug build: Process additional request info for CDP reporting
   requestInfo.headers = convertNSDictionaryToHeaders(request.allHTTPHeaderFields);
   requestInfo.httpBody = std::string((const char *)request.HTTPBody.bytes, request.HTTPBody.length);
+#endif
 
   NetworkReporter::getInstance().reportRequestStart(
       requestId.stringValue.UTF8String, requestInfo, encodedDataLength, std::nullopt);
@@ -49,7 +54,11 @@ + (void)reportResponseStart:(NSNumber *)requestId
   ResponseInfo responseInfo;
   responseInfo.url = response.URL.absoluteString.UTF8String;
   responseInfo.statusCode = statusCode;
+
+#ifdef REACT_NATIVE_DEBUGGER_ENABLED
+  // Debug build: Process additional request info for CDP reporting
   responseInfo.headers = convertNSDictionaryToHeaders(headers);
+#endif
 
   NetworkReporter::getInstance().reportResponseStart(
       requestId.stringValue.UTF8String, responseInfo, response.expectedContentLength);

packages/react-native/scripts/cocoapods/utils.rb

@@ -51,7 +51,9 @@ def self.set_gcc_preprocessor_definition_for_React_hermes(installer)
 
     def self.set_gcc_preprocessor_definition_for_debugger(installer)
         self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "REACT_NATIVE_DEBUGGER_ENABLED=1", "React-jsinspector", :debug)
+        self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "REACT_NATIVE_DEBUGGER_ENABLED=1", "React-RCTNetwork", :debug)
         self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "REACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1", "React-jsinspector", :debug)
+        self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "REACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1", "React-RCTNetwork", :debug)
     end
 
     def self.turn_off_resource_bundle_react_core(installer)