Skip to content

spi: nrfx_spim: initial pin state to SLEEP, not DEFAULT #93238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

spi: nrfx_spim: initial pin state to SLEEP, not DEFAULT #93238

wants to merge 1 commit into from
+4 −4

Conversation

JordanYates
Copy link
Contributor

Configure the initial pin state of the SPIM peripheral to SLEEP, not DEFAULT. This fixes the pins being configured in DEFAULT until the first time the interface is used if zephyr,pm-device-runtime-auto is enabled.

@JordanYates
spi: nrfx_spim: initial pin state to SLEEP, not DEFAULT
2ba1f1c 
Configure the initial pin state of the SPIM peripheral to SLEEP, not
DEFAULT. This fixes the pins being configured in DEFAULT until the first
time the interface is used if `zephyr,pm-device-runtime-auto` is
enabled.

Signed-off-by: Jordan Yates <jordan@embeint.com>
@zephyrbot zephyrbot added platform: nRF Nordic nRFx area: SPI SPI bus labels Jul 17, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anangl
anangl approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@anangl anangl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the same correction in spi_nrfx_spi.c as well?

@JordanYates
Copy link
Contributor Author

Could you make the same correction in spi_nrfx_spi.c as well?

spi_nrfx_spi.c does not use pm_device_driver_init so the same one-line change cannot be used there.
Updating that driver is a larger piece of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbursztyka tbursztyka tbursztyka approved these changes

@anangl anangl anangl approved these changes

@decsny decsny Awaiting requested review from decsny

@jaz1-nordic jaz1-nordic Awaiting requested review from jaz1-nordic

@kl-cruz kl-cruz Awaiting requested review from kl-cruz

@magp-nordic magp-nordic Awaiting requested review from magp-nordic

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

@teburd teburd Awaiting requested review from teburd

Assignees

@anangl anangl

@masz-nordic masz-nordic

Labels
area: SPI SPI bus platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanYates @tbursztyka @anangl @zephyrbot @masz-nordic