Skip to content

dts/boards: nordic: Fix reg and ranges property issues #93144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DematteisGiacomo
Copy link

@DematteisGiacomo DematteisGiacomo commented Jul 15, 2025

dts/boards: nordic: fix register properties
Add missing reg property to peripherals.

boards: nordic: nrf9280pdk: add ranges to reserved memory
Add missing "ranges".

boards: nordic: nrf9280pdk: remove /delete-node line
Remove /delete-node/ ipc-1-3; as this has no effect on the context.

Copy link

Hello @DematteisGiacomo, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@github-actions github-actions bot added the platform: nRF Nordic nRFx label Jul 15, 2025
@DematteisGiacomo DematteisGiacomo changed the title Fix reg and ranges property issues dts/boards: nordic: Fix reg and ranges property issues Jul 15, 2025
Comment on lines 10 to 11
#address-cells = <1>;
#size-cells = <1>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to re defined these are already defined in nrf9280.dtsi

Copy link
Contributor

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval implies that the changes requested by the vscode team were done. But we do not have scope and knowledge to determine any side effects. Please make sure someone who knows how these files are used in the SDK by apps and customers; also reviews these changes

maxd-nordic
maxd-nordic previously approved these changes Jul 15, 2025
Copy link
Contributor

@maxd-nordic maxd-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add missing reg property to peripherals.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Add missing "ranges".

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Remove `/delete-node/ ipc-1-3;` as this has no effect on the context.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Fix missing mapping for usbhs@86000 <0x2f700000 0x40000>
on parent node peripheral@5f000000.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants