-
Notifications
You must be signed in to change notification settings - Fork 7.7k
dts/boards: nordic: Fix reg and ranges property issues #93144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dts/boards: nordic: Fix reg and ranges property issues #93144
Conversation
Hello @DematteisGiacomo, and thank you very much for your first pull request to the Zephyr project! |
#address-cells = <1>; | ||
#size-cells = <1>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to re defined these are already defined in nrf9280.dtsi
32bc416
to
77b6bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval implies that the changes requested by the vscode team were done. But we do not have scope and knowledge to determine any side effects. Please make sure someone who knows how these files are used in the SDK by apps and customers; also reviews these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add missing reg property to peripherals. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Add missing "ranges". Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
Remove `/delete-node/ ipc-1-3;` as this has no effect on the context. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
77b6bfd
to
11b32fe
Compare
Fix missing mapping for usbhs@86000 <0x2f700000 0x40000> on parent node peripheral@5f000000. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
|
dts/boards: nordic: fix register properties
Add missing reg property to peripherals.
boards: nordic: nrf9280pdk: add ranges to reserved memory
Add missing "ranges".
boards: nordic: nrf9280pdk: remove /delete-node line
Remove
/delete-node/ ipc-1-3;
as this has no effect on the context.