drivers: led: Added driver for PCA9533 LED dimmer #92752
+386
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosyan-van
force-pushed
the
drivers_led_pca9533
branch
3 times, most recently
from
7b6c157 to
23b320f
Compare
github-actions
bot
added
area: LED
github-actions
bot
requested review from
dbaluta,
decsny,
dleach02,
jeppenodgaard,
Mani-Sadhasivam,
manuargue,
mmahadevan108,
Raymond0225 and
simonguinot
simonguinot
requested changes
Jul 16, 2025
There was a problem hiding this comment.
Hi @petrosyan-van,
Thanks for this LED driver. Please find a preliminary review below. I'll read it more carefully at the next pass.
simonguinot
requested review from
kartben,
soburi,
fabiobaltieri and
thedjnK
and removed request for
Raymond0225
petrosyan-van
force-pushed
the
drivers_led_pca9533
branch
2 times, most recently
from
cf4641c to
e917b96
Compare
Added DT binding for the PCA9533 LED Dimmer Signed-off-by: Van Petrosyan <van.petrosyan@sensirion.com>
petrosyan-van
force-pushed
the
drivers_led_pca9533
branch
2 times, most recently
from
e3c09e6 to
5094895
Compare
|
Thanks a lot for the feedback! |
petrosyan-van
force-pushed
the
drivers_led_pca9533
branch
from
5094895 to
0e97db4
Compare
• Supports led_on/off, led_set_brightness (0–100 %, 152 Hz default), and led_blink (7 ms – 1.685 s) with automatic sharing of the two on-chip PWM engines; returns –EBUSY when a third distinct pair is requested. • Includes basic runtime-PM boilerplate to honour power-domain control; the device itself has no dedicated low-power states. Signed-off-by: Van Petrosyan <van.petrosyan@sensirion.com>
PCA9533 is added to the overlay so the new driver is compiled by the automated “build all LED drivers” test Signed-off-by: Van Petrosyan <van.petrosyan@sensirion.com>
petrosyan-van
force-pushed
the
drivers_led_pca9533
branch
from
0e97db4 to
09a7c6e
Compare
|
fabiobaltieri
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a driver for the PCA9533 I2C LED dimmer with support for:
Tested on STM32U585 on a custom board. The chip has no specific power management features, but the driver includes PM hooks to respect power-domain relationships.
The PCA9533 is a simple 4-channel LED controller with two PWM engines that can be shared among LEDs.
Originally I was thinking to combine PCA9533 with PCA9633, but they actually have some major differences, like PWM engine limitation and inability to use PWM on all LED outputs at the same time on PCA9533