Skip to content

drivers: ethernet: phy: use default speeds props on the other phys #91572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

maass-hamburg
Copy link
Member

use the default speeds dt prop introduced here #89210 for phy_mii also on the other phys.

@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch 2 times, most recently from 2785c29 to b76ec40 Compare June 13, 2025 13:24
@maass-hamburg maass-hamburg marked this pull request as ready for review June 13, 2025 14:01
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch 3 times, most recently from 185bb90 to 0a2ddba Compare June 17, 2025 14:28
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch from 62e692e to dda4d30 Compare June 18, 2025 08:45
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch 2 times, most recently from a9dd949 to 24c9195 Compare June 18, 2025 13:40
@maass-hamburg
Copy link
Member Author

rebased due to now merged ci fix

@maass-hamburg maass-hamburg linked an issue Jun 30, 2025 that may be closed by this pull request
1 task
@maass-hamburg maass-hamburg linked an issue Jul 1, 2025 that may be closed by this pull request
1 task
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch from 24c9195 to 2f6c139 Compare July 2, 2025 06:06
@maass-hamburg
Copy link
Member Author

rebased to resolve confilicts

rruuaanng
rruuaanng previously approved these changes Jul 3, 2025
Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

move adi,adin1110.yaml adi,adin2111.yaml
from the phy subdir back into the ethernet dir.
They are ethernet controller bindings, not phy bindings.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
fixed link mode is a mode where we don't comunicate with the phy,
therefore we don't need it in other phys as the generic phy_mii one.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
split ethernet-phy.yaml, so that parts, that are used
by other phys are separated.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
remove the use of phy_configure_link() in the ethernet drivers.
The user can now select the default speeds via DT prop, doing
another phy_configure_link() in the eth driver would overwrite
that.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
put the macro to get the default speeds into a
shared header for the phys.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
- implement configure link
- support half duplex
- use defines from mii.h
- fix check ret vals

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use mutex to protect page register

phy_mc_vsc8541_get_link got removed from
phy_mc_vsc8541_link_cb_set so, that
phy_mc_vsc8541_link_monitor (own thread)
is the only one to change data->state

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds dt prop

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch from 2f6c139 to 5e306fb Compare July 9, 2025 13:32
@maass-hamburg maass-hamburg requested a review from rruuaanng July 9, 2025 13:35
Copy link

sonarqubecloud bot commented Jul 9, 2025

@rruuaanng rruuaanng self-assigned this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<err> eth_nxp_enet_mac: phy_configure_link failed with error: -88 eth_nxp_enet_mac failed with -120
4 participants