-
Notifications
You must be signed in to change notification settings - Fork 7.7k
drivers: ethernet: phy: use default speeds props on the other phys #91572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maass-hamburg
wants to merge
13
commits into
zephyrproject-rtos:main
Choose a base branch
from
maass-hamburg:ethernet_phy_default_speeds_all_phys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: ethernet: phy: use default speeds props on the other phys #91572
maass-hamburg
wants to merge
13
commits into
zephyrproject-rtos:main
from
maass-hamburg:ethernet_phy_default_speeds_all_phys
+180
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2785c29
to
b76ec40
Compare
185bb90
to
0a2ddba
Compare
62e692e
to
dda4d30
Compare
a9dd949
to
24c9195
Compare
rebased due to now merged ci fix |
Vijayakannan
approved these changes
Jun 18, 2025
1 task
This was referenced Jul 1, 2025
1 task
24c9195
to
2f6c139
Compare
rebased to resolve confilicts |
rruuaanng
previously approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
move adi,adin1110.yaml adi,adin2111.yaml from the phy subdir back into the ethernet dir. They are ethernet controller bindings, not phy bindings. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
fixed link mode is a mode where we don't comunicate with the phy, therefore we don't need it in other phys as the generic phy_mii one. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
split ethernet-phy.yaml, so that parts, that are used by other phys are separated. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
remove the use of phy_configure_link() in the ethernet drivers. The user can now select the default speeds via DT prop, doing another phy_configure_link() in the eth driver would overwrite that. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
put the macro to get the default speeds into a shared header for the phys. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
- implement configure link - support half duplex - use defines from mii.h - fix check ret vals Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com> Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use mutex to protect page register phy_mc_vsc8541_get_link got removed from phy_mc_vsc8541_link_cb_set so, that phy_mc_vsc8541_link_monitor (own thread) is the only one to change data->state Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds dt prop Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
2f6c139
to
5e306fb
Compare
|
rruuaanng
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Devicetree
area: Ethernet
platform: ADI
Analog Devices, Inc.
platform: NXP Drivers
NXP Semiconductors, drivers
platform: Xilinx
Xilinx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the default speeds dt prop introduced here #89210 for phy_mii also on the other phys.