Skip to content

drivers: led: shell: add blink cmd #90342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+45 −0
Open

drivers: led: shell: add blink cmd #90342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions drivers/led/led_shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ enum {
arg_idx_dev = 1,
arg_idx_led = 2,
arg_idx_value = 3,
arg_idx_delay_on = 3,
arg_idx_delay_off = 4,
};

static int parse_common_args(const struct shell *sh, char **argv,
Expand Down Expand Up @@ -85,6 +87,45 @@ static int cmd_on(const struct shell *sh, size_t argc, char **argv)
return err;
}

static int cmd_blink(const struct shell *sh, size_t argc, char **argv)
{
const struct device *dev;
uint32_t led, delay_on, delay_off;
char *end_ptr;
int err;

err = parse_common_args(sh, argv, &dev, &led);
if (err < 0) {
return err;
}

delay_on = strtoul(argv[arg_idx_delay_on], &end_ptr, 0);
if (*end_ptr != '\0') {
shell_error(sh, "Invalid delay_on parameter %s", argv[arg_idx_delay_on]);
return -EINVAL;
}

if (argc > arg_idx_delay_off) {
delay_off = strtoul(argv[arg_idx_delay_off], &end_ptr, 0);
if (*end_ptr != '\0') {
shell_error(sh, "Invalid delay_off parameter %s", argv[arg_idx_delay_off]);
return -EINVAL;
}
} else {
delay_off = delay_on;
}

shell_print(sh, "%s: blinking LED %d with %d ms on and %d ms off",
dev->name, led, delay_on, delay_off);

err = led_blink(dev, led, delay_on, delay_off);
if (err) {
shell_error(sh, "Error: %d", err);
}

return err;
}

static const char *led_color_to_str(uint8_t color)
{
switch (color) {
Expand Down Expand Up @@ -353,6 +394,10 @@ SHELL_STATIC_SUBCMD_SET_CREATE(
3, 0),
SHELL_CMD_ARG(on, &dsub_device_name, SHELL_HELP("Turn on LED", "<device> <led>"), cmd_on, 3,
0),
SHELL_CMD_ARG(blink, &dsub_device_name,
SHELL_HELP("Blink LED on and off",
"<device> <led> <delay_on_in_ms> [<delay_off_in_ms>]"),
cmd_blink, 4, 1),
SHELL_CMD_ARG(get_info, &dsub_device_name,
SHELL_HELP("Get LED information", "<device> <led>"), cmd_get_info, 3, 0),
SHELL_CMD_ARG(set_brightness, &dsub_device_name,
Expand Down