-
Notifications
You must be signed in to change notification settings - Fork 7.7k
modules: mcuboot: enable support for RAMLOAD mode with revert #85254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danieldegrasse
wants to merge
13
commits into
zephyrproject-rtos:main
Choose a base branch
from
danieldegrasse:feature/mcuboot-ramload-revert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+222
−53
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3e3ffaf
samples: subsys: mcumgr: rework ram load support for multiple boards
danieldegrasse 30d0aae
soc: nxp: common: disable FLASH_MCUX_FLEXSPI_XIP if using ramload
danieldegrasse 5e26130
samples: subsys: mgmt: mcumgr: add support for ramload on mimxrt1050_evk
danieldegrasse 42aff4d
modules: mcuboot: add Kconfigs for RAMLOAD_WITH_REVERT mode
danieldegrasse f17100e
scripts: ci: exempt BOOT_RAM_LOAD_REVERT from checks
danieldegrasse ed206f3
cmake: mcuboot: respect alignment size when signing for ramload mode
danieldegrasse 0baa5bd
cmake: mcuboot: prefer confirmed image when one is created
danieldegrasse 1923472
soc: nxp: flexspi_xip: Update FLASH_MCUX_FLEXSPI_XIP ramload dependen…
danieldegrasse dcc4c84
dfu: mcuboot: update dependencies for RAMLOAD_WITH_REVERT
danieldegrasse 222c060
manifest: update mcuboot revision for ramload support
danieldegrasse 15cad4d
dfu: boot: mcuboot: fix boot_fetch_active_slot
danieldegrasse f9506ba
mgmt: update img_mgmt_slot_in_use for ramload with revert mode
danieldegrasse 0c5ec1d
samples: mgmt: mcumgr: add testcase for ramload with revert
danieldegrasse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
samples/subsys/mgmt/mcumgr/smp_svr/boards/mimxrt1050_evk_hyperflash_ram_load.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
CONFIG_USE_DT_CODE_PARTITION=y |
53 changes: 53 additions & 0 deletions
53
samples/subsys/mgmt/mcumgr/smp_svr/boards/mimxrt1050_evk_hyperflash_ram_load.overlay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright (c) 2025 Tenstorrent AI ULC | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
/* | ||
* Layout must match the hyperflash_ram_load overlay file within mcuboot | ||
* application configuration directory | ||
*/ | ||
|
||
/delete-node/ &sdram0; | ||
|
||
/ { | ||
sram@80007F00 { | ||
compatible = "zephyr,memory-region", "mmio-sram"; | ||
reg = <0x80007F00 0x100>; | ||
zephyr,memory-region = "RetainedMem"; | ||
status = "okay"; | ||
|
||
retainedmem { | ||
compatible = "zephyr,retained-ram"; | ||
status = "okay"; | ||
#address-cells = <1>; | ||
#size-cells = <1>; | ||
|
||
boot_info0: boot_info@0 { | ||
compatible = "zephyr,retention"; | ||
status = "okay"; | ||
reg = <0x0 0x100>; | ||
}; | ||
}; | ||
}; | ||
|
||
chosen { | ||
zephyr,bootloader-info = &boot_info0; | ||
zephyr,sram = &sdram_split; | ||
}; | ||
|
||
/* | ||
* Adjust sdram0 to reserve first 30KB for MCUBoot, and | ||
* remaining 2KB for retained memory | ||
*/ | ||
sdram_split: sdram_split@80008000 { | ||
reg = <0x80008000 (0x2000000 - DT_SIZE_K(32))>; | ||
}; | ||
|
||
}; | ||
|
||
/* Reduce size of slot 0 to match slot 1 */ | ||
&slot0_partition { | ||
reg = <0x40000 0x300000>; | ||
}; |
36 changes: 35 additions & 1 deletion
36
samples/subsys/mgmt/mcumgr/smp_svr/boards/nrf52840dk_nrf52840_ram_load.overlay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
if("${FILE_SUFFIX}" STREQUAL "ram_load") | ||
set(mcuboot_EXTRA_DTC_OVERLAY_FILE "${CMAKE_CURRENT_LIST_DIR}/nrf52840dk_nrf52840_mcuboot_ram_load.overlay" CACHE INTERNAL "" FORCE) | ||
endif() | ||
|
||
find_package(Sysbuild REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
|
||
project(sysbuild LANGUAGES) |
33 changes: 0 additions & 33 deletions
33
samples/subsys/mgmt/mcumgr/smp_svr/sysbuild/nrf52840dk_nrf52840_mcuboot_ram_load.overlay
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little ambiguous to me, since the revert does kind of go back to an older version of the application. Not sure how to word it more clearly, though.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is true. Perhaps