-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Labels
area: SPISPI busSPI busarea: TestsIssues related to a particular existing or missing testIssues related to a particular existing or missing testbugThe issue is a bug, or the PR is fixing a bugThe issue is a bug, or the PR is fixing a bugpriority: lowLow impact/importance bugLow impact/importance bug
Description
Describe the bug
On SPI loopback test case:
this test case failed -[spi_loopback.test_nop_nil_bufs] on DMA mode GPIO CS line.
This case failed is because RX and TX are both NULL and there is no any transfer in fact.
CS line should not be asserted and deasserted.
But in test code, what CS check is always there whatever transfer happens or not.
/* There should be two CS triggers during the transaction, start and end */
zassert_false(spi_loopback_gpio_cs_loopback_check(2));
zassert_ok(pm_device_runtime_put(spec->bus));
I think it is not reasonable.
Regression
- This is a regression.
Steps to reproduce
-
Work on NXP RT1050 EVK board.
-
import spi_loopback example.
-
Modify mimxrt1050_evk_mimxrt1052_hyperflash.overlay file, add
/ {
zephyr,user {
cs-loopback-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
};
}; -
connect J24 pin4 and pin5, connect J24 pin2 and pin3
-
build and run.
Relevant log output
- FAIL - [spi_loopback.test_nop_nil_bufs] duration = 0.015 seconds
Impact
Annoyance – Minor irritation; no significant impact on usability or functionality.
Environment
Windows11, VSS , V4.1.99
Additional Context
No response
Metadata
Metadata
Assignees
Labels
area: SPISPI busSPI busarea: TestsIssues related to a particular existing or missing testIssues related to a particular existing or missing testbugThe issue is a bug, or the PR is fixing a bugThe issue is a bug, or the PR is fixing a bugpriority: lowLow impact/importance bugLow impact/importance bug